[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 2/6] x86/suspend: Don't bother saving %cr3, %ss or flags


  • To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
  • From: Roger Pau Monné <roger.pau@xxxxxxxxxx>
  • Date: Tue, 17 Dec 2019 13:18:13 +0100
  • Authentication-results: esa6.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none; spf=None smtp.pra=roger.pau@xxxxxxxxxx; spf=Pass smtp.mailfrom=roger.pau@xxxxxxxxxx; spf=None smtp.helo=postmaster@xxxxxxxxxxxxxxx
  • Cc: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Jan Beulich <JBeulich@xxxxxxxx>
  • Delivery-date: Tue, 17 Dec 2019 12:18:47 +0000
  • Ironport-sdr: agmmC8NxejyL+svwQLk2tXxyvD0JhtdK++JTRty/oVfeQbbh7tonxBYDQmw0DY1jdeE6+igm5w Z7r1f2MvqRiO2w8ZB1/W8PhVyId5huuZa6WzNIP3S3zr/Oq0xCB5HZBx8V7YYQZ9ulXAZbZ6Sp eSS53EBrrPUSTvpGhuWXao50Bu4zHI5F0iv8nw9WxNWf/x9n5yL5xzfG00WCxm8WsoOBMbTMCT gv6phJ0tmr/h8tq+UZ+5ouTSF4lMSwNuxGTnbeZ3IYjVgAJ1A6gU7FenUOA6R6XF2mlfFVkB5B O54=
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On Tue, Dec 17, 2019 at 12:06:01PM +0000, Andrew Cooper wrote:
> On 17/12/2019 11:52, Roger Pau Monné wrote:
> > On Fri, Dec 13, 2019 at 07:04:32PM +0000, Andrew Cooper wrote:
> >> The trampoline has already set up the idle pagetables (which are the 
> >> correct
> >> ones to use), and sanitised the flags state.
> > I wonder why do we have wakeup.S and wakeup_prot.S, it would be easier
> > to follow if it all was in the same file IMO.
> 
> wakeup.S is the 16bit entry point, and lives in the trampoline below 1M.
> 
> wakeup_prot.S is a bit of logic which lives in the main hypervisor.
> 
> The naming could probably do with some improvement, but they can't
> feasibly be part of the same file.

Hm, I'm not sure I follow. Isn't this trampoline copied by Xen in a
suitable position below the 1M boundary, and hence could use symbols
in order to figure out which part to copy?

Ie: both the low and the high part could live in the same file as long
as Xen knows how to differentiate those and which chunk needs
positioning below 1M?

Thanks, Roger.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.