Re: [Xen-devel] [PATCH] xen/page_alloc: statically allocate bootmem_region_list

[Julien Grall <julien@xxxxxxx>]

Hi Hongyan,

On 17/12/2019 14:33, Hongyan Xia wrote:
> The existing code assumes that the first mfn passed to the boot
> allocator is mapped, which creates problems when, e.g., we do not have
> a direct map, and may create other bootstrapping problems in the
> future. Make it static. The size is kept the same as before (1 page).
>
> Signed-off-by: Hongyan Xia <hongyxia@xxxxxxxxxx>
> ---
>   xen/common/page_alloc.c | 11 +++++------
>   1 file changed, 5 insertions(+), 6 deletions(-)
>
> diff --git a/xen/common/page_alloc.c b/xen/common/page_alloc.c
> index 7cb1bd368b..7afb651b79 100644
> --- a/xen/common/page_alloc.c
> +++ b/xen/common/page_alloc.c
> @@ -244,9 +244,12 @@ PAGE_LIST_HEAD(page_broken_list);
>    */
>   mfn_t first_valid_mfn = INVALID_MFN_INITIALIZER;
>   
> -static struct bootmem_region {
> +struct bootmem_region {
>       unsigned long s, e; /* MFNs @s through @e-1 inclusive are free */
> -} *__initdata bootmem_region_list;
> +};
> +/* Statically allocate a page for bootmem_region_list. */
> +static struct bootmem_region __initdata
> +    bootmem_region_list[PAGE_SIZE/sizeof(struct bootmem_region)];
NIT: space before and after /.

Other than that:

Reviewed-by: Julien Grall <julien@xxxxxxx>

Cheers,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel