[Xen-devel] [PATCH] libxc/restore: Don't duplicate state in process_vcpu_basic()

[Ian Jackson <ian.jackson@xxxxxxxxxx>]

Andrew Cooper writes ("[PATCH] libxc/restore: Don't duplicate state in 
process_vcpu_basic()"):
> vcpu_guest_context_any_t is currently allocated on the stack, and copied from
> a mutable buffer which is freed immediately after its use here.
> 
> Mutate the buffer in place instead of duplicating it.

It is not obvious to me that nothing uses the modified fields after
process_vcpu_basic has edited things.  The ctx of which the vcpu is
part is passed to process_vcpu_<various> by update_vcpu_context.

Why do you think this copying (which is extra code) was introduced ?

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel