Re: [Xen-devel] [PATCH] x86: Hyper-V clock source's offset should be signed

[Wei Liu <wl@xxxxxxx>]

On Fri, Dec 20, 2019 at 08:04:12PM +0000, Andrew Cooper wrote:
> On 20/12/2019 20:02, Wei Liu wrote:
> > On Fri, 20 Dec 2019 at 19:57, Andrew Cooper <andrew.cooper3@xxxxxxxxxx> 
> > wrote:
> >> On 20/12/2019 19:47, Wei Liu wrote:
> >>> Fixes: 685d16bd5 (x86: implement Hyper-V clock source)
> >>> Signed-off-by: Wei Liu <liuwe@xxxxxxxxxxxxx>
> >>> ---
> >>> I discover this stupid mistake when I work on extracting common code
> >>> from viridian and the clock source implementation.
> >> Does it make a practical difference?
> >>
> > Probably not. The specs says that field is signed, so our code should
> > reflect that.
> 
> Fair enough.  Acked-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx> (with
> the inline fix as well)

Thanks. I will commit this now.

Wei.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel