[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Xen-devel] [PATCH V6 2/4] x86/altp2m: Add hypercall to set a range of sve bits
- To: Alexandru Stefan ISAILA <aisaila@xxxxxxxxxxxxxxx>
- From: Jan Beulich <JBeulich@xxxxxxxx>
- Date: Fri, 27 Dec 2019 08:01:50 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hsWcCCmo5rkHD87BEzkWsbyrqp7CnygNtddp1cHXRcM=; b=aNOih5w5/qZwFgq5wAh9ZfgedQhdDbSReyznckkRl0KhATMB0B+oLl8/07/31zhA2dUqTGlYYsD+mr4scPreLPPDBpwyhb7CPsAWDgucffC9zSNSy5UaN/W80fi4J2Wx8a8+oHg/KFnOMcArzL/UWNoea1cUuCWDKdryUJISNgg3jyIcO9Iwi1zFHTEERiKIDqEnDrjNj2Jx9eNYzBaF1RaFPl7d/CcJBgcYn10DmrUjmT/aIRPm9iIDnW6NAstXjUiKMPsHznV6BdsXIiiwnfEIHUr2UMfCVy+ZiTufNVgywbxX9k8/E+Z7g1jMNe8gh+8s5YjXez4TWLTec0b5pg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BCXsG7yXsWkryWF4exuGX1VD1qWAR+svfadB5tGOPbR3+xX3m9PLFWN2fKVzn4TLptrPUfYO8jYcyqdUtT9Xv6uANHu/p2b2YQUldd8P/8rfe7k+FoNll8XuADmd2fqB5fpbzEwnWJAc1S5/cHPHE3zmKdro0rQWUvI1P0XZflSE76pmO0oQESfeRE6hENE3YsQha7/md0f268aoOtlJaOsOzOI3xamaaQXCHMwYR3ad47S3Pyy2RrHNsQcOLbSLJXOcrFV1VUvGB3qvOoL+gRT+NH8qXnbesod3oFH3/eXQF0qSfiNtE+mH3EnIkJQv2cbfIPu5/WUqTx1uZhFEbw==
- Authentication-results: spf=none (sender IP is ) smtp.mailfrom=JBeulich@xxxxxxxx;
- Cc: Petre Ovidiu PIRCALABU <ppircalabu@xxxxxxxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Razvan COJOCARU <rcojocaru@xxxxxxxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>, George Dunlap <George.Dunlap@xxxxxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Ian Jackson <ian.jackson@xxxxxxxxxxxxx>, Tamas K Lengyel <tamas@xxxxxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Delivery-date: Fri, 27 Dec 2019 08:05:15 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHVuZoDNmDuDnEJ80qPa8O4OJEXKqfNpLkA
- Thread-topic: [PATCH V6 2/4] x86/altp2m: Add hypercall to set a range of sve bits
(re-sending, as I still don't see the mail having appeared on the list)
On 23.12.2019 15:04, Alexandru Stefan ISAILA wrote:
> --- a/xen/include/public/hvm/hvm_op.h
> +++ b/xen/include/public/hvm/hvm_op.h
> @@ -46,6 +46,16 @@ struct xen_hvm_altp2m_suppress_ve {
> uint64_t gfn;
> };
>
> +struct xen_hvm_altp2m_suppress_ve_multi {
> + uint16_t view;
> + uint8_t suppress_ve; /* Boolean type. */
> + uint8_t pad1;
> + int32_t first_error; /* Should be set to 0 . */
Stray blank before full stop.
> + uint64_t first_gfn; /* Value may be updated */
> + uint64_t last_gfn;
> + uint64_t first_error_gfn; /* Gfn of the first error. */
> +};
Please be consistent about your comment style here: The full
stop isn't mandatory, but at least adjacent comments (all
added at the same time) should have identical style.
Please may I ask that you apply a little more care when doing
updates, rather than relying on others to spend their time on
catching issues?
Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel
|
