Re: [Xen-devel] [PATCH] tools/libxl: Reposition build_pre() logic between architectures

[Julien Grall <julien@xxxxxxx>]

Hi Andrew,

On 27/12/2019 13:45, Andrew Cooper wrote:
> The call to xc_domain_disable_migrate() is made only from x86, while its
> handling in Xen is common.  Move it to the libxl__build_pre().
>
> hvm_set_conf_params(), hvm_set_viridian_features(),
> hvm_set_mca_capabilities(), and the altp2m logic is all in common
> code (parts ifdef'd) but despite this, is all actually x86 specific.
While altp2m is only supported on x86, the concept is not x86-specific. 
I am actually aware of people using altp2m on Arm, althought the support 
is not upstream yet.
> Move it into x86 specific code, and fold all of the xc_hvm_param_set() calls
> together into hvm_set_conf_params() in a far more coherent way.
>
> Finally - ensure that all hypercalls have their return values checked.
>
> No practical change in constructed domains.  Fewer useless hypercalls now to
> construct an ARM guest.
I think it would be best to keep anything that we know can be used on 
arm (or new architecture) in common code. I am thinking about 
"nestedhvm" and "altp2m".
Cheers,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel