|
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [PATCH v2 1/3] x86: relax GDT check in arch_set_info_guest()
On 27.12.2019 16:09, Andrew Cooper wrote: > On 20/12/2019 13:49, Jan Beulich wrote: >> It is wrong for us to check frames beyond the guest specified limit >> (in the native case, other than in the compat one). >> >> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx> > > Just like the restriction on sharing L2's, no guest is ever going to be > able to not zero all of this to operate on older hypervisors. > > I agree that it is not ideal that this got into the ABI to begin with, > but as I said before, all you are doing is complicating > arch_set_info_guest() for a relaxation which no guest can use. As asked before - would you mind clarifying where I'm complicating things? I think I'm rather simplifying matters, by - pulling out a calculation, storing the result into a now common (between native and compat cases) local variable, - as a result making native and compat cases behave consistently, eliminating the need for reader to (try to) figure out why there is a difference in behavior. Jan _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxxxxxxxxx https://lists.xenproject.org/mailman/listinfo/xen-devel
|
 |
Lists.xenproject.org is hosted with RackSpace, monitoring our |