Re: [Xen-devel] [PATCH RFC v3 8/8] x86emul: support MCOMMIT

[Jan Beulich <jbeulich@xxxxxxxx>]

On 06.01.2020 20:45, Andrew Cooper wrote:
> On 06/01/2020 16:39, Jan Beulich wrote:
>> The dependency on a new EFER bit implies that we need to set that bit
>> ourselves in order to be able to successfully invoke the insn.
>>
>> Also once again introduce the SVM related constants at this occasion.
>>
>> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
>> ---
>> RFC: The exact meaning of the PM stating "any errors encountered by
>>      those stores have been signaled to associated error logging
>>      resources" is unclear. Depending on what this entails, blindly
>>      enabling EFER.MCOMMIT may not be a good idea. Hence the RFC.
> 
> From what I gather, this is only going to be useful in combination with
> future features.
> 
> While I have no specific concerns code wise, I'd recommend deferring the
> patch until we have a better idea of how it is supposed to be used. 

Right - hence the RFC. I have a supposed-to-be-used inquiry pending
with AMD.

> (Especially given the PCOMMIT debacle on Intel.)

;-)

Jan

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel