Re: [Xen-devel] [PATCH 1/2] x86/hyperv: drop usage of GENMASK_ULL from hyperv-tlfs.h

[Wei Liu <wl@xxxxxxx>]

On Wed, Jan 08, 2020 at 01:26:20PM +0100, Jan Beulich wrote:
> On 07.01.2020 18:39, Wei Liu wrote:
> > --- a/xen/include/asm-x86/guest/hyperv-tlfs.h
> > +++ b/xen/include/asm-x86/guest/hyperv-tlfs.h
> > @@ -415,13 +415,13 @@ enum HV_GENERIC_SET_FORMAT {
> >     HV_GENERIC_SET_ALL,
> >  };
> >  
> > -#define HV_HYPERCALL_RESULT_MASK   GENMASK_ULL(15, 0)
> > +#define HV_HYPERCALL_RESULT_MASK   0xffff /* GENMASK_ULL(15, 0) */
> >  #define HV_HYPERCALL_FAST_BIT              BIT(16, UL)
> >  #define HV_HYPERCALL_VARHEAD_OFFSET        17
> >  #define HV_HYPERCALL_REP_COMP_OFFSET       32
> > -#define HV_HYPERCALL_REP_COMP_MASK GENMASK_ULL(43, 32)
> > +#define HV_HYPERCALL_REP_COMP_MASK 0xfff00000000 /* GENMASK_ULL(43, 32) */
> >  #define HV_HYPERCALL_REP_START_OFFSET      48
> > -#define HV_HYPERCALL_REP_START_MASK        GENMASK_ULL(59, 48)
> > +#define HV_HYPERCALL_REP_START_MASK        0xfff000000000000 /* 
> > GENMASK_ULL(59, 48) */
> 
> The last two should gain ULL (or at least UL) suffixes. I also
> wonder whether both wouldn't better be expressed as (0xfffULL << N).
> With at least the suffixes added

Thanks. I will fix those up.

Using (0xffffULL << N) works for me too. Let's see what form Paul
prefers.

Wei.

> Acked-by: Jan Beulich <jbeulich@xxxxxxxx>
> 
> Jan

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel