Re: [Xen-devel] [PATCH 2/2] x86/hyperv: drop all __packed from hyperv-tlfs.h

["Durrant, Paul" <pdurrant@xxxxxxxxxxxx>]

> -----Original Message-----
> From: Xen-devel <xen-devel-bounces@xxxxxxxxxxxxxxxxxxxx> On Behalf Of Wei
> Liu
> Sent: 08 January 2020 12:27
> To: Paul Durrant <pdurrant@xxxxxxxxx>
> Cc: Wei Liu <liuwe@xxxxxxxxxxxxx>; Wei Liu <wl@xxxxxxx>; Andrew Cooper
> <andrew.cooper3@xxxxxxxxxx>; Michael Kelley <mikelley@xxxxxxxxxxxxx>; Jan
> Beulich <JBeulich@xxxxxxxx>; Xen Development List <xen-
> devel@xxxxxxxxxxxxxxxxxxxx>; Roger Pau Monné <roger.pau@xxxxxxxxxx>
> Subject: Re: [Xen-devel] [PATCH 2/2] x86/hyperv: drop all __packed from
> hyperv-tlfs.h
> 
> On Wed, Jan 08, 2020 at 09:11:12AM +0000, Paul Durrant wrote:
> > On Tue, 7 Jan 2020 at 17:39, Wei Liu <wl@xxxxxxx> wrote:
> > >
> > > All structures are already naturally aligned. Linux added those
> > > attributes out of paranoia.
> > >
> > > In Xen we've had instance we had to drop pointless __packed to placate
> > > gcc 9 (see ca9310b24e
> >
> > I think you should add:
> >
> > "x86/IO-APIC: fix build with gcc9"
> >
> > here.
> 
> I have fixed it up locally. Do you want me to resend these two patches
> just for this update?

As long as it is fixed when committed any way will do.

  Paul

> 
> Wei.
> 
> >
> > > ), it is better drop those attributes.
> > >
> > > Requested-by: Jan Beulich <jbeulich@xxxxxxxx>
> > > Signed-off-by: Wei Liu <liuwe@xxxxxxxxxxxxx>
> >
> >   Paul
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxxxxxxxxx
> https://lists.xenproject.org/mailman/listinfo/xen-devel
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel