[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Xen-devel] [PATCH V7 2/4] x86/altp2m: Add hypercall to set a range of sve bits
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Alexandru Stefan ISAILA <aisaila@xxxxxxxxxxxxxxx>
- Date: Mon, 13 Jan 2020 13:44:12 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=bitdefender.com; dmarc=pass action=none header.from=bitdefender.com; dkim=pass header.d=bitdefender.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YsqIG8L8/k0RZacIg058OtaCpsViRbYKIKNHM1ife2E=; b=QxTDnSRuDbxhmURvzoEpGm4RXA4F+5nmiNNuZ4/+tuSOl1YgbMZkPDJRiKpmFBNnIByWyyTo0BuU90qBqtoE3LfN5B/oilhlhkQeJqwwQmCuEgvVoGMR4wNG3Jp4yZEeHmwknJ7rrCYY36ws8By3ZV7onSEM6GDG9HM+lhoW5xxiCTDozTs/laB+m5WFO6AflqTCn7Rjk7mGF58AqnVXmHVhw4aNhuCX0eOymHvZj3wfBBwR1QsSKoDHKGwNwKASLj4HXhBEcXPR+/MI7rSeBGXP5CrPxpCGgWs0Fppt7d8mKnQzSh6eMydo8AbFfoBwUIldvT9eRC1Bux66y1+0ow==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cTJEhWGTq6w6XAdoBBJxyw650kZRyf3/7EZIrbB2S6BSG/v2Udn9JVAI47L5qqpvQYTTeJB3+ubrWZ6emHLkhDaQoaBXOcdk7390lFkSk0OSe97nXd1y3vfv9aH1pmSbj7UZRv3TqMd7NoAtzWXh18JsTk9pJO2mFF3u0ZRF3T0QeRSAvXNdqE8vIIbnZhwOHl5+4y5bQ07vpRxx//HHzVT+7z3mQMdrICF2FvNFj7jXKarHmZF7Ziei1j0wc4rk3G/Lh9jniiU/Scmb0mbKcD1c1lAa3CzVaKrlG3VuWhHmfFtbRyXLeN4/2857YL9i9JChyFR1I8TCpnEGktbzNA==
- Authentication-results: spf=none (sender IP is ) smtp.mailfrom=aisaila@xxxxxxxxxxxxxxx;
- Cc: Petre Ovidiu PIRCALABU <ppircalabu@xxxxxxxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Razvan COJOCARU <rcojocaru@xxxxxxxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>, George Dunlap <George.Dunlap@xxxxxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Ian Jackson <ian.jackson@xxxxxxxxxxxxx>, Tamas K Lengyel <tamas@xxxxxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Delivery-date: Mon, 13 Jan 2020 13:44:17 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHVxi0eW7mND/zIzUWDdK2ePPvUVqfkF1AAgARVogCAACerAIAADhkA
- Thread-topic: [Xen-devel] [PATCH V7 2/4] x86/altp2m: Add hypercall to set a range of sve bits
On 13.01.2020 14:53, Jan Beulich wrote:
> On 13.01.2020 11:32, Alexandru Stefan ISAILA wrote:
>> On 10.01.2020 18:20, Jan Beulich wrote:
>>> On 08.01.2020 15:08, Alexandru Stefan ISAILA wrote:
>>>> + if ( !(rc = p2m_set_suppress_ve_multi(d, &sve)) && sve.first_error )
>>>> + rc = sve.first_error;
>>>
>>> Why the right side of the && ?
>>
>> This is intended to have p2m_set_suppress_ve() call
>> p2m_set_suppress_ve_multi(). So here first I call the _multi version and
>> the check if there was any error from the set/get (that is what
>> p2m_set_suppress_ve did before).
>
> To put my original question differently: from a functionality pov,
> how would
>
> if ( !(rc = p2m_set_suppress_ve_multi(d, &sve)) )
> rc = sve.first_error; >
> be different from your variant (as long as the field indeed starts
> out as zero)?
It will be the same in this case and it can be dropped.
>
>> I don't know why git made the patch so ugly.
>
> I have no idea what ugliness you refer to here.
>
I was talking about the fact that the changes in p2m_set_suppress_ve()
got mixed with the ones in p2m_set_suppress_ve_multi().
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel
|
