Re: [Xen-devel] [PATCH 3/4] xen/domain: Remove #ifndef surrounding alloc_pirq_struct()

[Jan Beulich <jbeulich@xxxxxxxx>]

On 13.01.2020 22:33, Julien Grall wrote:
> --- a/xen/include/xen/domain.h
> +++ b/xen/include/xen/domain.h
> @@ -41,9 +41,7 @@ struct vcpu *alloc_vcpu_struct(const struct domain *d);
>  void free_vcpu_struct(struct vcpu *v);
>  
>  /* Allocate/free a PIRQ structure. */
> -#ifndef alloc_pirq_struct
>  struct pirq *alloc_pirq_struct(struct domain *);
> -#endif
>  void free_pirq_struct(void *);

Is this really a helpful change. Back then ia64 had a #define for
this, and a future port may want to do so as well. Is there
anything actively problematic with leaving this untouched?

Jan

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel