[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 1/4] xen/x86: Remove unused forward declaration in asm-x86/irq.h



Hi Jan,

On 14/01/2020 09:31, Jan Beulich wrote:
On 13.01.2020 22:33, Julien Grall wrote:
From: Julien Grall <jgrall@xxxxxxxxxx>

None of the prototypes within the header asm-x86/irq.h actually requires
the forward declaration of "struct pirq". So remove it.

No functional changes intended.

Signed-off-by: Julien Grall <jgrall@xxxxxxxxxx>

Acked-by: Jan Beulich <jbeulich@xxxxxxxx>

It is generally nice to identify if this was missed cleanup (the
need indeed went away in 4.12), or if such has never really been
needed.

Yes it is nice to have but this is a best effort basis for cleanup. They are not fixes and therefore not going to be backported. So I don't feel the need to browse more than 15 years worth of history and check whether a cleanup were missed.

What matter for cleanup is the current context and whether they make sense now.

Anyway, I would be happy to add a word in the commit message if you point me to the commit removing the need.

Cheers,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.