Re: [Xen-devel] [PATCH] xen/vcpu: Improve sanity checks in vcpu_create()

[Julien Grall <julien@xxxxxxx>]

Hi,

On 16/01/2020 09:55, Jan Beulich wrote:
> On 15.01.2020 19:44, Andrew Cooper wrote:
> > The BUG_ON() is confusing to follow.  The (!is_idle_domain(d) || vcpu_id) part
> > is a vestigial remnant of architectures poisioning idle_vcpu[0] with non-NULL
> > pointers.
> >
> > Now that idle_vcpu[0] is NULL on all architectures, and d->max_vcpus specified
> > before vcpu_create() is called, we can properly range check the requested
> > vcpu_id.
> I guess this is meant to be true on top of your Arm side change
> which hasn't been committed yet? And perhaps better "... starts
> out as NULL on all ..."?
I can commit the two together.

> > Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>
Acked-by: Julien Grall <julien@xxxxxxx>

Cheers,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel