[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Xen-devel] [PATCH v2 1/2] xen: add config option to include failing condition in BUG_ON() message
- To: Jan Beulich <jbeulich@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- From: Jürgen Groß <jgross@xxxxxxxx>
- Date: Fri, 17 Jan 2020 09:53:22 +0100
- Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Wei Liu <wl@xxxxxxx>, Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>, George Dunlap <George.Dunlap@xxxxxxxxxxxxx>, IanJackson <ian.jackson@xxxxxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx, Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Delivery-date: Fri, 17 Jan 2020 08:53:36 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 17.01.20 09:39, Jan Beulich wrote:
On 16.01.2020 19:54, Andrew Cooper wrote:
On 14/01/2020 16:12, Jan Beulich wrote:
On 14.01.2020 17:00, Jürgen Groß wrote:
On 14.01.20 16:47, Jan Beulich wrote:
On 09.01.2020 14:48, Juergen Gross wrote:
--- a/xen/Kconfig.debug
+++ b/xen/Kconfig.debug
@@ -81,6 +81,12 @@ config PERF_ARRAYS
---help---
Enables software performance counter array histograms.
+config DEBUG_BUGVERBOSE
+ bool "Verbose BUG_ON messages"
+ default DEBUG
+ ---help---
+ In case a BUG_ON triggers additionally print the triggering
+ condition on the console.
config VERBOSE_DEBUG
While I can see reasons to put this here, doing so means the option
will be unavailable in non-EXPERT release builds. Is it intended to
be that way?
I can move it either to xen/Kconfig or in Kconfig.debug out of the
"if expert" section if you want.
I think this would be better, but give others a chance to voice
opinions.
TBH, I don't think anyone will be interested in not having the strings.
The change is what? a couple of hundred bytes? That is a fraction of
the size of some functions we have.
Well, it's a couple thousand (about 7k according to my simplistic
estimation, but this is taking Arm and x86 together). It's not the
end of the world, but in particular embedded users may want to get
rid of this. There's a reason after all (I assume) that Linux has
the option.
The needed code churn is rather limited, so I think we should keep the
config option.
Juergen
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel
|
