Re: [Xen-devel] [PATCH v4 06/16] libxl: write qemu arguments into separate xenstore keys

[Jason Andryuk <jandryuk@xxxxxxxxx>]

On Tue, Jan 14, 2020 at 9:41 PM Marek Marczykowski-Górecki
<marmarek@xxxxxxxxxxxxxxxxxxxxxx> wrote:
>
> This allows using arguments with spaces, like -append, without
> nominating any special "separator" character.
>
> Signed-off-by: Marek Marczykowski-Górecki <marmarek@xxxxxxxxxxxxxxxxxxxxxx>
> ---
> Changes in v3:
>  - previous version of this patch "libxl: use \x1b to separate qemu
>    arguments for linux stubdomain" used specific non-printable
>    separator, but it was rejected as xenstore doesn't cope well with
>    non-printable chars
> ---

The code looks good.

Reviewed-by: Jason Andryuk <jandryuk@xxxxxxxxx>

One thought I have is dmargs is a string for mini-os and a directory
for linux stubdom.  It's toolstack managed, so it's not a problem.
But would a different xenstore node be less surprising to humans?

Regards,
Jason

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel