[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Xen-devel] [PATCH] arm/acpi: Add __acpi_unmap_table function for ARM
- To: Wei Xu <xuwei5@xxxxxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Alexandru Stefan ISAILA <aisaila@xxxxxxxxxxxxxxx>
- Date: Tue, 21 Jan 2020 10:01:22 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=bitdefender.com; dmarc=pass action=none header.from=bitdefender.com; dkim=pass header.d=bitdefender.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FzXBLiba4Aik8WezPwLr+0iN2pakAWZlvNBSbmjEm9s=; b=lptLFTS2kbWCFyUe5gKnnBgbpRbKyo/5L4kEVI/za9OBzoRn3hSWlaYg68Q77q2FSw/ZCCfX6aVh2o3tojbt3Vl+koYVtQD9AIo7jjXhtK4jDjqKVeS3O6eUfRtJa3zAJurAYtkm/CX/CCyoETFltDYFGCX8gLgY3WjI/lK3+8TmuhGVyUnicBoKGPtp56jXRYQ/JZWae/dbfe0xXfjtAXmTQdkRe8rSCCK5DH/MPptF61OrmQ6E4wxaXqywQPy00xvhaZuzUYlELwSk+RW2MOBrUJdClZBGtjp/WGox1ZZqri8C3tkrwSMYSPNhmeldhkjgs0sflKNWXmLRebR13w==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OPEZUlRp12fZ+arCcD9yHKQQCtVHjJ0uWGBPT8r/LgJBiARcoznrlzXxe7ThH8FlJvlFTlbop6fGsdC2NSqS/xdzqnBIZ2x79dL5R9XqzFlajDHR47PXNf+apz+0RZzT+4IfZXNnNEVIdQFn5m/lJuP3TKiLVeh+sEJbcDeCLpQilm4yxfwPjlCZRRYpSEja1szxr5kDzYde9hYZwBBhPXwjLGwhCzoXQ201PGZFuWvHXpEm+hWAGqLSoTK+/R4wodybR/0W7W9qRpzYBANTzyvl3w+1KQuMcbPBM7PqJja5MoOQHGRud5fCT0705rQzXdbVZ+7ELdTUhh0AZGUhGQ==
- Authentication-results: spf=none (sender IP is ) smtp.mailfrom=aisaila@xxxxxxxxxxxxxxx;
- Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Wei Liu <wl@xxxxxxx>, Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>, George Dunlap <George.Dunlap@xxxxxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Ian Jackson <ian.jackson@xxxxxxxxxxxxx>, Linuxarm <linuxarm@xxxxxxxxxx>, Shameerali Kolothum Thodi <shameerali.kolothum.thodi@xxxxxxxxxx>, "Zengtao \(B\)" <prime.zeng@xxxxxxxxxxxxx>, "Volodymyr_Babchuk@xxxxxxxx" <Volodymyr_Babchuk@xxxxxxxx>
- Delivery-date: Tue, 21 Jan 2020 10:01:35 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHV0EBzyX2it6CDtUGAF3Arvy+eQaf04vQA
- Thread-topic: [Xen-devel] [PATCH] arm/acpi: Add __acpi_unmap_table function for ARM
On 21.01.2020 11:49, Wei Xu wrote:
> Add __acpi_unmap_table function for ARM and invoke it at acpi_os_unmap_memory
> to make sure the related fixmap has been cleared before using it for a
> different mapping.
>
> Signed-off-by: Wei Xu<xuwei5@xxxxxxxxxxxxx>
> ---
> xen/arch/arm/acpi/lib.c | 25 +++++++++++++++++++++++++
> xen/drivers/acpi/osl.c | 2 ++
> xen/include/xen/acpi.h | 1 +
> 3 files changed, 28 insertions(+)
>
> diff --git a/xen/arch/arm/acpi/lib.c b/xen/arch/arm/acpi/lib.c
> index 4fc6e17..69e87ec 100644
> --- a/xen/arch/arm/acpi/lib.c
> +++ b/xen/arch/arm/acpi/lib.c
> @@ -49,6 +49,31 @@ char *__acpi_map_table(paddr_t phys, unsigned long size)
> return ((char *) base + offset);
> }
>
> +void __acpi_unmap_table(void __iomem * virt, unsigned long size)
You have a stray space here after "*"
> +{
> + unsigned long base, end;
> + int idx;
> +
> + base = FIXMAP_ADDR(FIXMAP_ACPI_BEGIN);
> + end = FIXMAP_ADDR(FIXMAP_ACPI_END);
Maybe the initialization can be moved to the declaration?
Alex
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel
|
