Re: [Xen-devel] [PATCH] x86/suspend: disable watchdog before calling console_start_sync()

[Igor Druzhinin <igor.druzhinin@xxxxxxxxxx>]

On 28/01/2020 13:39, Jan Beulich wrote:
> On 27.01.2020 22:29, Igor Druzhinin wrote:
>> @@ -223,6 +224,7 @@ static int enter_state(u32 state)
>>  
>>      acpi_sleep_prepare(state);
>>  
>> +    watchdog_disable();
>>      console_start_sync();
>>      printk("Entering ACPI S%d state.\n", state);
>>  
>> @@ -281,6 +283,7 @@ static int enter_state(u32 state)
>>          tboot_s3_error(error);
>>  
>>      console_end_sync();
>> +    watchdog_enable();
>>  
>>      microcode_update_one(true);
> 
> Between these two there's a "goto done;" which also wants
> watchdog_enable() added then.

Indeed, thanks for noticing. Will send v2 shortly.

Igor

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel