Re: [Xen-devel] [PATCH v6 5/9] x86/mem_sharing: use default_access in add_to_physmap

[Tamas K Lengyel <tamas.k.lengyel@xxxxxxxxx>]

On Tue, Jan 28, 2020 at 9:56 AM Jan Beulich <jbeulich@xxxxxxxx> wrote:
>
> On 27.01.2020 19:06, Tamas K Lengyel wrote:
> > When plugging a hole in the target physmap don't use the access permission
> > returned by __get_gfn_type_access as it can be non-sensical, leading to
> > spurious vm_events being sent out for access violations at unexpected
> > locations. Make use of p2m->default_access instead.
>
> As before, to me "can be non-sensical" is insufficient as a reason
> here. If it can also be a "good" value, it still remains unclear
> why in that case p2m->default_access is nevertheless the right
> value to use.

I have already explained in the previous version of the patch why I
said "can be". Forgot to change the commit message from "can be" to
"is".

Tamas

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel