[Xen-devel] [PATCH v5 12/15] drm/udl: Don't set struct drm_crtc_state.no_vblank explictly

[Thomas Zimmermann <tzimmermann@xxxxxxx>]

As udl does not initialize vblanking, atomic helpers initialize the
value of struct drm_crtc_state.no_vblank to be true. No need to set
it from within the driver.

Signed-off-by: Thomas Zimmermann <tzimmermann@xxxxxxx>
Acked-by: Gerd Hoffmann <kraxel@xxxxxxxxxx>
Reviewed-by: Daniel Vetter <daniel.vetter@xxxxxxxx>
---
 drivers/gpu/drm/udl/udl_modeset.c | 11 -----------
 1 file changed, 11 deletions(-)

diff --git a/drivers/gpu/drm/udl/udl_modeset.c 
b/drivers/gpu/drm/udl/udl_modeset.c
index 22af17959053..d59ebac70b15 100644
--- a/drivers/gpu/drm/udl/udl_modeset.c
+++ b/drivers/gpu/drm/udl/udl_modeset.c
@@ -375,8 +375,6 @@ udl_simple_display_pipe_enable(struct 
drm_simple_display_pipe *pipe,
        char *wrptr;
        int color_depth = UDL_COLOR_DEPTH_16BPP;
 
-       crtc_state->no_vblank = true;
-
        buf = (char *)udl->mode_buf;
 
        /* This first section has to do with setting the base address on the
@@ -428,14 +426,6 @@ udl_simple_display_pipe_disable(struct 
drm_simple_display_pipe *pipe)
        udl_submit_urb(dev, urb, buf - (char *)urb->transfer_buffer);
 }
 
-static int
-udl_simple_display_pipe_check(struct drm_simple_display_pipe *pipe,
-                             struct drm_plane_state *plane_state,
-                             struct drm_crtc_state *crtc_state)
-{
-       return 0;
-}
-
 static void
 udl_simple_display_pipe_update(struct drm_simple_display_pipe *pipe,
                               struct drm_plane_state *old_plane_state)
@@ -457,7 +447,6 @@ struct drm_simple_display_pipe_funcs 
udl_simple_display_pipe_funcs = {
        .mode_valid = udl_simple_display_pipe_mode_valid,
        .enable = udl_simple_display_pipe_enable,
        .disable = udl_simple_display_pipe_disable,
-       .check = udl_simple_display_pipe_check,
        .update = udl_simple_display_pipe_update,
        .prepare_fb = drm_gem_fb_simple_display_pipe_prepare_fb,
 };
-- 
2.25.0


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel