Re: [Xen-devel] [XEN PATCH v2.1 13/12] Makefile: Fix install-tests

[Jan Beulich <jbeulich@xxxxxxxx>]

On 21.01.2020 14:59, Anthony PERARD wrote:
> The top-level makefile make uses of internal implementation detail of
> the xen build system. Avoid that by creating a new target
> "install-tests" in xen/Makefile, and by fixing the top-level Makefile
> to not call xen/Rules.mk anymore.
> 
> Signed-off-by: Anthony PERARD <anthony.perard@xxxxxxxxxx>

This in principle could have my R-b, but ...

> --- a/xen/Makefile
> +++ b/xen/Makefile
> @@ -90,6 +90,9 @@ _install: $(TARGET)$(CONFIG_XEN_INSTALL_SUFFIX)
>  .PHONY: _tests
>  _tests:
>       $(MAKE) -f $(BASEDIR)/Rules.mk -C test tests
> +.PHONY: install-tests
> +install-tests:
> +     $(MAKE) -f $(BASEDIR)/Rules.mk -C test install

... I'm irritated by the patch context here: Patch 8 changed
_tests to tests, and by the numbering this patch goes on top
of patch 8. Could you clarify what's going on here, please?

Jan

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel