Re: [Xen-devel] [PATCH 2/2] xen/x86: hap: Clean-up and harden hap_enable()

[Julien Grall <julien@xxxxxxx>]

On 04/02/2020 12:36, Jan Beulich wrote:
> On 04.02.2020 12:44, Julien Grall wrote:
> > Aside the MISRA, there are some cases where I feel the explicit
> > comparisons make sense. But I don't have any rational for them and view
> > this as a matter of taste. So I would leave it to the author of the
> > patch the choice.
> FWIW, I disagree on this aspect. Consistency of the code base
> is, I think, more important an aspect. Yes, we likely never
> won't reach a fully consistent state, as goals shift, but
> anyway.
The meaning of consistency is quite broad. What you view as consistent 
may not be for me (and vice versa). So we are down to the "matter of 
taste" territory.
We could suggest to be consistent with the code surrounding, but I think 
you will not be happy with it as some code does not suit the coding 
style (see the recent discussion about using __).
Cheers,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel