Re: [Xen-devel] [PATCH] xen: make sure stop_machine_run() is always called in a tasklet

[Jürgen Groß <jgross@xxxxxxxx>]

On 14.02.20 15:06, Igor Druzhinin wrote:
> On 11/02/2020 09:35, Juergen Gross wrote:
> > With core scheduling active it is mandatory for stop_machine_run() to
> > be called in a tasklet only, as otherwise a scheduling deadlock would
> > occur: stop_machine_run() does a cpu rendezvous by activating a tasklet
> > on all other cpus. In case stop_machine_run() was not called in an idle
> > vcpu it would block scheduling the idle vcpu on its siblings with core
> > scheduling being active, resulting in a hang.
> I suppose rcu_barrier() is fine due to process_pending_softirqs() being
> called inside? I'm a little concerned by imposing is_vcpu_idle() restriction
> in that case as rcu_barrier() could be technically called from a non-tasklet
> context.
No, stop_machine_run() with core scheduling active can only work when
called in an idle vcpu.

OTOH it would be fairly easy to add another softirq for a similar
purpose and have a sync_machine_run() using that instead of tasklets.
This could be used for ucode loading, too.

stop_machine_run() and sync_machine_run() could use a common main
function. The patch should be rather simple.

Thoughts?


Juergen

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel