[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] amd/iommu: add missing unlock in iommu_read_log


  • To: Roger Pau Monne <roger.pau@xxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
  • Date: Wed, 19 Feb 2020 11:23:40 +0000
  • Authentication-results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none; spf=None smtp.pra=andrew.cooper3@xxxxxxxxxx; spf=Pass smtp.mailfrom=Andrew.Cooper3@xxxxxxxxxx; spf=None smtp.helo=postmaster@xxxxxxxxxxxxxxx
  • Cc: Jan Beulich <jbeulich@xxxxxxxx>
  • Delivery-date: Wed, 19 Feb 2020 11:24:09 +0000
  • Ironport-sdr: M8TiydU6e0BnBcTq8AN4hzXoFaQFr/okxdkiehY9N8XcXdjOkJDBWuryQbkJBt7G/3Po4m67Jg fZH+oJ7WIvcjyo3I+o8xjCYO1XkCS0kWUAMBcIHlB/2IBy6UfmY0QtannD3W/VYS/Re1ZzKj4O Zi+XP3F6IThnnhJbCRaYsQ8Tnx/gOBlxvleD4bu4aMNq5sqRdX79MeImujdsTdDl4vNKdyM+rA WplFQD2qzPsVkeJdwGZeEN2fe87xum3MYxuw79MhoZMilOxfVnOZfuiI3qDGRCcwmS5i2M/p7P Rwc=
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 19/02/2020 11:19, Roger Pau Monne wrote:
> Reported-by: Coverity
> CID: 1458632

We tend to use just Coverity-ID: 1458632

> Fixes: 709d3ddea2d5e ('AMD/IOMMU: Common the #732/#733 errata handling in 
> iommu_read_log()')
> Signed-off-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
> ---
>  xen/drivers/passthrough/amd/iommu_init.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/xen/drivers/passthrough/amd/iommu_init.c 
> b/xen/drivers/passthrough/amd/iommu_init.c
> index 4c86848c52..e93a090830 100644
> --- a/xen/drivers/passthrough/amd/iommu_init.c
> +++ b/xen/drivers/passthrough/amd/iommu_init.c
> @@ -338,6 +338,7 @@ static int iommu_read_log(struct amd_iommu *iommu,
>              {
>                  AMD_IOMMU_DEBUG("AMD-Vi: No entry written to %s Log\n",
>                                  log == &iommu->event_log ? "Event" : "PPR");
> +                spin_unlock(&log->lock);

A goto out would be cleaner.  Can fix up on commit if you're happy?

~Andrew

>                  return 0;
>              }
>              udelay(1);


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.