Re: [Xen-devel] [PATCH v2] sysctl: use xmalloc_array() for XEN_SYSCTL_page_offline_op

[Julien Grall <julien@xxxxxxx>]

On 19/02/2020 12:49, Jan Beulich wrote:
> Julien,
>
> On 18.02.2020 17:53, Andrew Cooper wrote:
> > On 18/02/2020 16:52, Jan Beulich wrote:
> > > This is more robust than the raw xmalloc_bytes().
> > >
> > > Also add a sanity check on the input page range, to avoid returning
> > > the less applicable -ENOMEM in such cases (and trying the allocation in
> > > the first place).
> > >
> > > Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
> > Acked-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> I notice you've committed this, but somehow you've lost Andrew's
> ack. I don't think it was intended by the recent check-in policy
> change for commits to go in without suitable acks (iirc I did
> notice a few others recently as well, albeit not ones committed
> by you).
In this case, this was a lack of attention while committing the patch.

Mistakes can happen and this has nothing to do with a check-in policy.
You will never be able to fully prevent any mistakes until you remove 
the human from the equation. Please provide scripts that fully automate 
the committers job if you are concern about this.
Cheers,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel