[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] x86/build: Fix -mskip-rax-setup handling

On Fri, Feb 21, 2020 at 06:55:50PM +0000, Andrew Cooper wrote:
> The way -mskip-rax-setup is currently specified results in compiler support
> being evaluated per translation unit, rather than per subdir.  Switch to using
> cc-add-option instead.
> This drops the number of callouts from 428 to 60.
> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> ---
> CC: Jan Beulich <JBeulich@xxxxxxxx>
> CC: Wei Liu <wl@xxxxxxx>
> CC: Roger Pau Monné <roger.pau@xxxxxxxxxx>
> CC: Anthony PERARD <anthony.perard@xxxxxxxxxx>
> This drops about 0.5s from my ccache-accelerated but otherwise-clean build,
> and will likely have a more pronounced difference on older hardware.  If it
> wants backporting, it wants to go back in this form.
> Alternatively, it would be nice to get this moved to Kconfig time.  Anthony:
> Do you have any part of your series already doing this, or any suggestions on
> how best to do it without colliding with your work?

The version of my series that I've sent some time ago (v2) already do
better than this :-P, since that would get call only once in
xen/Makefile (instead of everytime Rules.mk is called again).

I don't have a better suggestion that could work without colliding with
my series, but it won't be too hard to rebase.


Anthony PERARD

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.