[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Xen-devel] [PATCH v9 3/5] xen/mem_sharing: VM forking
- To: Tamas K Lengyel <tamas@xxxxxxxxxxxxx>
- From: Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Date: Tue, 25 Feb 2020 10:40:09 +0100
- Authentication-results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none; spf=None smtp.pra=roger.pau@xxxxxxxxxx; spf=Pass smtp.mailfrom=roger.pau@xxxxxxxxxx; spf=None smtp.helo=postmaster@xxxxxxxxxxxxxxx
- Cc: Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Tamas K Lengyel <tamas.lengyel@xxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Ian Jackson <ian.jackson@xxxxxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Tue, 25 Feb 2020 09:40:43 +0000
- Ironport-sdr: Q2q2/lCzerg6IVlgF9Taw8RS8E7DpKJHboVjUirvl6/igkOx7vY4X56IYW8wkQ9QujDLFzVHnw qA/vA9A8oUNR0kd6bIdDsVG/cI68VQkrOjvXz6E/kWJFqnf3SxoE0ar2+i0acaZmnSc0vAoPEL GNiHiGiaKtKRqMowYOyOWPVRh4zChL0aZ1q43IhrYemIfgwoWDmECI8RykI1mXPzxf5Kr/OYYN /ebrHHk9w5y3ybesllF9Yzfh3bpf2HyM+WgjjiOaMipGo9qc/4ZXgUHdTzD+AIxQ9j9AzLderi LwU=
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Mon, Feb 24, 2020 at 03:14:56PM -0700, Tamas K Lengyel wrote:
> > > > +int mem_sharing_fork_page(struct domain *d, gfn_t gfn, bool unsharing)
> > > > +{
> > > > + int rc = -ENOENT;
> > > > + shr_handle_t handle;
> > > > + struct domain *parent;
> > >
> > > Can you constify parent, I assume there are no changes made to the
> > > parent domain, just the forked one.
> >
> > Sure.
>
> Actually, no can't do. The parent could get modified here, since we
> could end up making the parent's memory into shared entries. So using
> const here is not justified since the parent can and does get
> modified.
Oh, that's fine.
Roger.
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel
|
