Re: [Xen-devel] [PATCH] xen/grant-table: Remove outdated warning in gnttab_grow_table()

[Jan Beulich <jbeulich@xxxxxxxx>]

On 25.02.2020 14:29, Andrew Cooper wrote:
> On 25/02/2020 13:25, Julien Grall wrote:
>> One of the warning message in gnttab_grow_table() refers to a function
>> was removed in commit 6425f91c72 "xen/gnttab: Fold grant_table_{create,
>> set_limits}() into grant_table_init()".
>>
>> Since the commit, gt->active will be allocated while initializing the
>> grant table at domain creation. Therefore gt-active will always be
>> valid.
>>
>> Rather than replacing the warning by another one, we can now downgrade
>> the check to an ASSERT().
>>
>> Signed-off-by: Julien Grall <jgrall@xxxxxxxxxx>
> 
> TBH, I'd drop the assert.

+1 fwiw

Jan

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel