[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 2/2] domain: use PGC_extra domheap page for shared_info

On 26.02.2020 15:22, Julien Grall wrote:
> On 26/02/2020 12:03, Durrant, Paul wrote:
>>> From: Julien Grall <julien@xxxxxxx>
>>> Sent: 26 February 2020 11:33
>>> On 25/02/2020 09:53, Paul Durrant wrote:
>>>> For Arm, the call to free_shared_info() in arch_domain_destroy() is left
>>>> in place since it called in the error path for arch_domain_create().
>>>> NOTE: A modification in p2m_alloc_table() is required to avoid a false
>>>>         positive when checking for domain memory.
>>>>         A fix is also needed in dom0_construct_pv() to avoid
>>> automatically
>>>>         adding PGC_extra pages to the physmap.
>>> I am not entirely sure how this is related to this patch. Was it a
>>> latent bug? If so, I think it would make sense to split it from this
>>> patch.
>> It's related because the check relies on the fact that no PGC_extra pages 
>> are created before it is called. This is indeed true until this patch is 
>> applied.
> I would prefer if they are fixed in separate patches as this pach 
> already quite a lot. But I will leave that up to Andrew and Jan.

I agree with Julien (if splitting is sensibly possible), fwiw.


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.