[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 03/10] x86/gen-cpuid: Rework internal logic to ease future changes

  • To: Jan Beulich <jbeulich@xxxxxxxx>
  • From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
  • Date: Thu, 27 Feb 2020 10:08:48 +0000
  • Authentication-results: esa4.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none; spf=None smtp.pra=andrew.cooper3@xxxxxxxxxx; spf=Pass smtp.mailfrom=Andrew.Cooper3@xxxxxxxxxx; spf=None smtp.helo=postmaster@xxxxxxxxxxxxxxx
  • Cc: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>
  • Delivery-date: Thu, 27 Feb 2020 10:09:10 +0000
  • Ironport-sdr: bwza4W+3cfVWnXvnmOhxM3AisFwzp7TCi1xThiOU3/ISX1OZpQ1GB1VSvy912FqtaOr2wOdNyH Cbu/J87bMtTFrRIcV73pyT03UH9rxtd0dMmxRn9SQaL03dYqYvrikDmKAqnih7R9axhRX9PjNz Zg5BQMWmiiplyJfuZm/7bzv3zIp/o2vQ+NSAqGcjKZR4Zuxg9x1burdzCyGVolzauzSzNYbmmH MnDN7U9ncJgC1fQY1mC9zq7evv5ry/LSQwx1JQRx79DbIW/key47yEVkJE8AlbguH+pNBux3Wt xD0=
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 27/02/2020 07:57, Jan Beulich wrote:
> On 26.02.2020 21:22, Andrew Cooper wrote:
>> Better split the logic between parse/calculate/write.  Collect the feature
>> comment by their comment character, and perform the accumulation operations 
>> in
>> crunch_numbers().
> Would you mind saying "character(s)" here, as there are items with
> multiple of them?


>> Avoid rendering the featuresets to C uint32_t's in crunch_numbers(), and
>> instead do this in write_results().  Update format_uint32s() to call
>> featureset_to_uint32s() internally.
>> No functional change - the generated cpuid-autogen.h is identical.
> I notice the "special" field (or however such is called in Python)
> goes away, in favor of using raw['!'] at the apparently sole
> consuming site. I also notice the same isn't true for "pv", which
> now could also be raw['A'] as it seems. If this is the case (i.e.
> I'm not overlooking anything), could you say a word on the change
> for "special" and/or the difference between "special" and "pv"?

There is no point copying data just for the sake of copying data.

While we could drop state.pv (pv_def by the end of the series), that is
the only set it would be true for, and dropping it does interfere with
the derivation of raw_shadow (raw_shadow_def by the end of the series).


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.