Re: [Xen-devel] [PATCH] credit2: avoid NULL deref in csched2_res_pick() when tracing

[Jürgen Groß <jgross@xxxxxxxx>]

On 02.03.20 09:58, Jan Beulich wrote:
> The issue here results from one of the downsides of using goto: The
> early "goto out" and "goto out_up" in the function very clearly bypass
> any possible initialization of min_rqd, yet the tracing code at the end
> of the function consumes the value. There's even a comment regarding the
> trace record not being accurate in this case.
>
> CID: 1460432
> Fixes: 9c84bc004653 ("sched: rework credit2 run-queue allocation")
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
Reviewed-by: Juergen Gross <jgross@xxxxxxxx>


Juergen

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel