Re: [Xen-devel] [PATCH] xen: Use 'unsigned int' instead of 'unsigned'

[Yan Yankovskyi <yyankovskyi@xxxxxxxxx>]

On Mon, Mar 2, 2020 at 10:11 AM Jan Beulich <jbeulich@xxxxxxxx> wrote:

> ... evtchn_port_t here and elsewhere.

There are some interfaces with signed int as a type for port, e.g. in include/xen/events.h.

Should I create additional patch to resolve inconsistency with evtchn interface?

Or you suggest combining these changes into the existing patch?

Also as I understand 'evtchn' and 'port' are essentially the same entities

from perspective of local domain, related to each other roughly like connection

and file descriptor pair. What do you think about renaming all 'evtchn' arguments

and variables to 'port'? It will eliminate inconsistencies in the code, for example

in include/xen/interface/event_channel.h and include/xen/events.h.

Yan

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel