[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Xen-devel] [PATCH] libxenstat: fixed Makefile for building python-bindings
- To: xen-devel@xxxxxxxxxxxxxxxxxxxx
- From: Jonas Licht <jonas.licht@xxxxxxxxxxxxxxxxx>
- Date: Wed, 4 Mar 2020 18:29:39 +0100
- Autocrypt: addr=jonas.licht@xxxxxxxxxxxxxxxxx; prefer-encrypt=mutual; keydata= mQINBFUAuaIBEAC3OEog5gZmx2hdTwZwT02CZzfB9Zw4XSk4vR/CfgIXwkqPXTNxppLF7N3s lRTPFInsvkkEC9Er7QNqx5uMITwwFTU/d5CBOmjW0hPJrXGZDUsm+u/QB+EG9sQtCz38XlX5 hAkm4ZnAU7SFcNyoGaR+ilX4uNhzl7DzgzInXHrLrffInchYQBCXXP1d5M6uYyah5Tzf418l nx+OfNTARtEknev2XrHu07LNI/ufdAmz0LUMR+Cc4V+gxAa/978Y0KdDTor1Jpd1Tjdb4nAk ioFNyeAm9pS4AMFj6YGXCopmMskR8AcS9P5KHiLSq8OXBVVk1lSKKEEXmiPBl0bJ5pOZuCRV hyse9RabUBZIj9UtlFE1EAyUvTQWClwQZSi04+FkC7mzVLExWpi5jxPfx8hDBY9fjqc35jIN Nv3P+eZQSs4z3T2OfcVXKYTh45u4HZaxlyjeQUTh+zbwHYPqMkhASbO4Vahk09jtkZoXHPdd 7GRP2822x0O4RpRquEXgnp6SqFWYYSNDDDbd3cS+IcasAb+VHoAVqF4upt9C/kvKTA6IndjB jYQhkvAniPocbPZZ9FQHfl57AJXvagArFjNwn83Yf/efcrlqwnAO5W1IRtBpI/qY6LfbjDIY aQGh9kahYbsORhrCmG1pPOOKjcFgXIgtxT/PS8HovXxd/sowUwARAQABtCtKb25hcyBMaWNo dCA8am9uYXMubGljaHRAZmVtLnR1LWlsbWVuYXUuZGU+iQI4BBMBAgAiBQJYeUSZAhsDBgsJ CAcDAgYVCAIJCgsEFgIDAQIeAQIXgAAKCRBvS+fzGZpbwWEfD/wLB8H4Foior52NhRcCx2G7 kIp0kFW/jOSjFiciEOWfQRQCOasdFwhgnz8mttm7pscZ4EW3CUoouy1oj4y6yhnSySD7ToOE tpv46yRs+Uo/c+P6VUGar6WF/bmlKMkD9LhjNV64e+MbdGeqV7IUivPvDmlm6jmHA3dzuCEw uCI9W01PQ+gqE6ftZjlXGRPF8qxfPeaOwoviiNhcOrIieKRs1pqOccbKfFbalIU60XyQfXxW R5KkpuH+t63Z+UCMIGihqDE9OZhEm+47VaE8AQlbYUHlsEwoy7VaKbKOezdeorInV3v5DHQe ErokwXpaHgjYbU/TDydXeKFlb7SDr8JPr65m7Hmr71KMDAwhlxVIoNUsUadC6QC6mN+hIGPi f8rVlhQfXyT4UIeMaOtvXldajcKt1eUkT8WR5pI6yYDweZ6QNhV+HtwUPGiCdaMbV3t3n3jC IyEchlQaT4XWUX2+U1OgD3PYbPKGVLymnk5lm83vIsrNFAxh67KzU/Ru0/CdlK6BPm3ATkuY yqi48BdHJZq/7Pop/6mdVzMHetNWdbDL9Qppd8cCKx1WztbchlDivlPu3ereJPPnbe1kltUy LcdLeZw+JkhSFCpkWMwnJkHtSf4CZW7SUR+48RRTXU2CfssminpWCDho6wRqXQcqOhkVCqBg YvnvkskrsqnLHrkCDQRVALnwARAAmptEZQeCv5MogP/PhrideIuQEVphSI7UqBFp5g9+rR6J C3MGBD6mP5PE8OZ1AK3G775+qiaIcZS1sAPNgmcasw8WXqxI9ScAzambUcg7esOU/vpN0JiI tvpqLcR1Vorb/nZ3lHAKsnHZ5MZeWJJWrWJvbId7W6tBDXEEX7BYEjI4GepkQI+nBZzh4xsf 5rFSOYdYw7E31YoKhwfIPuUUM+OrIoUW9bRRMvG5EP28H84XNo0/rWYtdhJ7LrHZ5mk0UXSk 4QiJbOltJc69DUrvoWrQOP0cBRaKYm+oMfHbgf0YlRwABlwaaR2c3SNY01RgSMs64Z5CGJUz G6zFxETDqunRBXzdUC/c0MfEG8jPyVwQqC/1QP660rOQLcDSQJch200V0nf+p3ZEITm9Iei1 pQ7a1UHnzSJWrnp8FKPN5lKL2WVSwXEiAk7HNcTxPe3W4YqNDIGap/id9FRsSX88QMfNXI0S 4PHPZ8I/MYcrrDnKd99M1bQA/6M1v1/5oS4v3ZB8unleYa91G/iHJsACOTqHKirEc7Exwy4D AKchzmFOWwtz7OA6EhxYAP5w9gO8CCJWCiTu3bgyW+Vfequ8tyYIWgTCwKrkcatTLZTIvJVI 7YPl5Q1OQ3A4rvkHET70pikJj2dU8Fc4mxvCoKYCDAmgEA6KLdo52fbRqTdbzZUAEQEAAYkC HwQYAQgAEwUCVQC6IAkQb0vn8xmaW8ECGwwAAC1oD/wP4XPGblXAhqp9Ghvc4ZXXq1HLAL05 tfgvObNXds09/bZY5N/JIsB+n202OKqa63sQNO7xOd8NZplljR1dRGAyGCqQjkMcFELq7Bvk 45VKsC2d6yyxhhdIoiW+I3+cCIJ+rQB4c4GjaM2Ro36eIBbbf1tbnEIOnf7uaeR/14xWX7I+ lxEzqRQicjHOEZAjfAimtdSKrqo6PRkSedjCYvaop8miillPZIRYaTnwoHQ7nW/n9gCrk/gF hGxBTXGhrZ6LvLAKYrhSzKBGtQn95QuH8plJtrzw6xTQWd1i6k3nWBhC6lat6O98CdLnRyiY QivWf5Q3WQJvAjerVfUlxxYmDUzlRxA71Pob9hSyu9GamNwDQVGjXv86GSf7xmSRfc7ASiI1 tEufWyHvPd01xPSbd9bGM4chWmXdEh+E38QqFpXKdgIyRqZr6X71PvfNx0V4Jlz8vVjr3KKT k255OFj+vwafTBz4twIjHb8CfXMzAEnDtW6H4wCP11fY/j+LsCeFkhTYCmqcbBPVtdYxCZPh CPmavnRRBGqDvis3Sx33RA16SY9Xi3ZLOiXhlrP71hBMwC0DuCikVqx7x6COwzW27vlcsvRP +aviDfK27qT529hrz37Q7hq7oQSP98dks/KDPS7mmEw1s2o8uAvCrI0c6ugVd2ENQN5K5gnn ZbSb8Q==
- Cc: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>, Wei Liu <wl@xxxxxxx>
- Delivery-date: Wed, 04 Mar 2020 17:30:01 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
Am 04.03.20 um 11:31 schrieb Wei Liu:
> Hi Jonas
Hi Wei
> Thanks for this patch.
>
> On Mon, Mar 02, 2020 at 06:53:38PM +0100, jonas.licht@xxxxxxxxxxxxxxxxx wrote:
>> Fixes the libxenstat Makefile to determine the correct paths
>> of python includes when building python-bindings.
>> Also replaces the -lxenstat linking to correct object files
>> and use the libdir variable for installing.
>>
>> Signed-off-by: Jonas Licht <jonas.licht@xxxxxxxxxxxxxxxxx>
>> ---
>> tools/xenstat/libxenstat/Makefile | 11 +++++------
>> 1 file changed, 5 insertions(+), 6 deletions(-)
>>
>> diff --git a/tools/xenstat/libxenstat/Makefile
>> b/tools/xenstat/libxenstat/Makefile
>> index 03cb212e3b..4a02d2e563 100644
>> --- a/tools/xenstat/libxenstat/Makefile
>> +++ b/tools/xenstat/libxenstat/Makefile
>> @@ -114,18 +114,17 @@ $(BINDINGS): $(SHLIB) $(SHLIB_LINKS) src/xenstat.h
>> SWIG_FLAGS=-module xenstat -Isrc
>>
>> # Python bindings
>> -PYTHON_VERSION=$(PYTHON:python%=%)
>> -PYTHON_FLAGS=-I/usr/include/python$(PYTHON_VERSION)
>> -lpython$(PYTHON_VERSION)
>> +PYTHON_FLAGS=`$(PYTHON) -c 'import distutils.sysconfig; print("-I" +
> A better approach would be to use python-config here.
I'm not quite sure if I can require the python-config tool is installed.
As I see it's not checked by the configure.
I've seen some configure scripts, which has an extra fallback when
python-config is missing.
I was inspired by the m4/python_devel.m4 script too.
Best regards,
Jonas
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel
|
