[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v4 2/6] x86 / p2m: remove page_list check in p2m_alloc_table...



On 09.03.2020 10:35, paul@xxxxxxx wrote:
> From: Paul Durrant <pdurrant@xxxxxxxxxx>
> 
> ... and replace with a check of domain_tot_pages().
> 
> The check of page_list prevents the prior allocation of PGC_extra pages,
> whereas what the code is trying to verify is that the toolstack has not
> already RAM for the domain.
> 
> Signed-off-by: Paul Durrant <paul@xxxxxxx>

Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>
preferably with "remove" in the subject replaced by the "replace"
currently at the beginning of the description. (It also looks as
if there was "allocated" or some such missing near the end of the
description.)

Jan

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.