Re: [Xen-devel] [XEN PATCH v2 1/2] xen/arm: Rename all early printk macro

[Anthony PERARD <anthony.perard@xxxxxxxxxx>]

On Fri, Mar 06, 2020 at 03:57:23PM -0800, Stefano Stabellini wrote:
> On Fri, 6 Mar 2020, Anthony PERARD wrote:
> > We also reuse CONFIG_EARLY_PRINTK provided by users to enable or not
> > early printk, thus we need to override the value in makefile.
> > 
> > Signed-off-by: Anthony PERARD <anthony.perard@xxxxxxxxxx>
> 
> I tried this patch and it breaks the build with EARLY_PRINTK. With:
> 
> export CONFIG_EARLY_PRINTK=zynqmp
> 
> I get:
> 
> /local/repos/gcc-linaro-5.3.1-2016.05-x86_64_aarch64-linux-gnu/bin/aarch64-linux-gnu-gcc
>  -D__ASSEMBLY__ -DBUILD_ID -fno-strict-aliasing -Wall -Wstrict-prototypes 
> -Wdeclaration-after-statement -Wno-unused-but-set-variable 
> -Wno-unused-local-typedefs -O1 -fno-omit-frame-pointer -nostdinc -fno-builtin 
> -fno-common -Werror -Wredundant-decls -Wno-pointer-arith -Wvla -pipe 
> -D__XEN__ -include /local/repos/xen-upstream/xen/include/xen/config.h 
> '-D__OBJECT_FILE__="arm64/head.o"' -Wa,--strip-local-absolute -g -MMD -MF 
> arm64/.head.o.d -mcpu=generic -mgeneral-regs-only -DCONFIG_EARLY_PRINTK 
> -DCONFIG_EARLY_PRINTK_INC=\"debug-y.inc\" -DCONFIG_EARLY_UART_BAUD_RATE= 
> -DCONFIG_EARLY_UART_BASE_ADDRESS= -DCONFIG_EARLY_UART_8250_REG_SHIFT= 
> -I/local/repos/xen-upstream/xen/include -fno-stack-protector -fno-exceptions 
> -Wnested-externs -c arm64/head.S -o arm64/head.o
> arm64/head.S:49:33: fatal error: debug-y.inc: No such file or directory
> 
> I take the patch was not expected to do that?

I didn't about users providing CONFIG_EARLY_PRINTK via the environment,
and I'm changing the value, so that fails.

There's two way to provide CONFIG_EARLY_PRINTK:
- via make
    make CONFIG_EARLY_PRINTK=zynqmp
- via the environment
    CONFIG_EARLY_PRINTK=zynqmp make

I've only tested the first scenario, that why I have an override. But
that doesn't work with the second scenario.

So renaming the make variable EARLY_PRINTK to CONFIG_EARLY_PRINTK will
have to wait until the second patch of the series.

Thanks,

-- 
Anthony PERARD

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel