[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Xen-devel] nvmx deadlock with MSR bitmaps


  • To: xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
  • Date: Wed, 11 Mar 2020 18:04:03 +0000
  • Authentication-results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none; spf=None smtp.pra=andrew.cooper3@xxxxxxxxxx; spf=Pass smtp.mailfrom=Andrew.Cooper3@xxxxxxxxxx; spf=None smtp.helo=postmaster@xxxxxxxxxxxxxxx
  • Autocrypt: addr=andrew.cooper3@xxxxxxxxxx; prefer-encrypt=mutual; keydata= xsFNBFLhNn8BEADVhE+Hb8i0GV6mihnnr/uiQQdPF8kUoFzCOPXkf7jQ5sLYeJa0cQi6Penp VtiFYznTairnVsN5J+ujSTIb+OlMSJUWV4opS7WVNnxHbFTPYZVQ3erv7NKc2iVizCRZ2Kxn srM1oPXWRic8BIAdYOKOloF2300SL/bIpeD+x7h3w9B/qez7nOin5NzkxgFoaUeIal12pXSR Q354FKFoy6Vh96gc4VRqte3jw8mPuJQpfws+Pb+swvSf/i1q1+1I4jsRQQh2m6OTADHIqg2E ofTYAEh7R5HfPx0EXoEDMdRjOeKn8+vvkAwhviWXTHlG3R1QkbE5M/oywnZ83udJmi+lxjJ5 YhQ5IzomvJ16H0Bq+TLyVLO/VRksp1VR9HxCzItLNCS8PdpYYz5TC204ViycobYU65WMpzWe LFAGn8jSS25XIpqv0Y9k87dLbctKKA14Ifw2kq5OIVu2FuX+3i446JOa2vpCI9GcjCzi3oHV e00bzYiHMIl0FICrNJU0Kjho8pdo0m2uxkn6SYEpogAy9pnatUlO+erL4LqFUO7GXSdBRbw5 gNt25XTLdSFuZtMxkY3tq8MFss5QnjhehCVPEpE6y9ZjI4XB8ad1G4oBHVGK5LMsvg22PfMJ ISWFSHoF/B5+lHkCKWkFxZ0gZn33ju5n6/FOdEx4B8cMJt+cWwARAQABzSlBbmRyZXcgQ29v cGVyIDxhbmRyZXcuY29vcGVyM0BjaXRyaXguY29tPsLBegQTAQgAJAIbAwULCQgHAwUVCgkI CwUWAgMBAAIeAQIXgAUCWKD95wIZAQAKCRBlw/kGpdefoHbdD/9AIoR3k6fKl+RFiFpyAhvO 59ttDFI7nIAnlYngev2XUR3acFElJATHSDO0ju+hqWqAb8kVijXLops0gOfqt3VPZq9cuHlh IMDquatGLzAadfFx2eQYIYT+FYuMoPZy/aTUazmJIDVxP7L383grjIkn+7tAv+qeDfE+txL4 SAm1UHNvmdfgL2/lcmL3xRh7sub3nJilM93RWX1Pe5LBSDXO45uzCGEdst6uSlzYR/MEr+5Z JQQ32JV64zwvf/aKaagSQSQMYNX9JFgfZ3TKWC1KJQbX5ssoX/5hNLqxMcZV3TN7kU8I3kjK mPec9+1nECOjjJSO/h4P0sBZyIUGfguwzhEeGf4sMCuSEM4xjCnwiBwftR17sr0spYcOpqET ZGcAmyYcNjy6CYadNCnfR40vhhWuCfNCBzWnUW0lFoo12wb0YnzoOLjvfD6OL3JjIUJNOmJy RCsJ5IA/Iz33RhSVRmROu+TztwuThClw63g7+hoyewv7BemKyuU6FTVhjjW+XUWmS/FzknSi dAG+insr0746cTPpSkGl3KAXeWDGJzve7/SBBfyznWCMGaf8E2P1oOdIZRxHgWj0zNr1+ooF /PzgLPiCI4OMUttTlEKChgbUTQ+5o0P080JojqfXwbPAyumbaYcQNiH1/xYbJdOFSiBv9rpt TQTBLzDKXok86M7BTQRS4TZ/ARAAkgqudHsp+hd82UVkvgnlqZjzz2vyrYfz7bkPtXaGb9H4 Rfo7mQsEQavEBdWWjbga6eMnDqtu+FC+qeTGYebToxEyp2lKDSoAsvt8w82tIlP/EbmRbDVn 7bhjBlfRcFjVYw8uVDPptT0TV47vpoCVkTwcyb6OltJrvg/QzV9f07DJswuda1JH3/qvYu0p vjPnYvCq4NsqY2XSdAJ02HrdYPFtNyPEntu1n1KK+gJrstjtw7KsZ4ygXYrsm/oCBiVW/OgU g/XIlGErkrxe4vQvJyVwg6YH653YTX5hLLUEL1NS4TCo47RP+wi6y+TnuAL36UtK/uFyEuPy wwrDVcC4cIFhYSfsO0BumEI65yu7a8aHbGfq2lW251UcoU48Z27ZUUZd2Dr6O/n8poQHbaTd 6bJJSjzGGHZVbRP9UQ3lkmkmc0+XCHmj5WhwNNYjgbbmML7y0fsJT5RgvefAIFfHBg7fTY/i kBEimoUsTEQz+N4hbKwo1hULfVxDJStE4sbPhjbsPCrlXf6W9CxSyQ0qmZ2bXsLQYRj2xqd1 bpA+1o1j2N4/au1R/uSiUFjewJdT/LX1EklKDcQwpk06Af/N7VZtSfEJeRV04unbsKVXWZAk uAJyDDKN99ziC0Wz5kcPyVD1HNf8bgaqGDzrv3TfYjwqayRFcMf7xJaL9xXedMcAEQEAAcLB XwQYAQgACQUCUuE2fwIbDAAKCRBlw/kGpdefoG4XEACD1Qf/er8EA7g23HMxYWd3FXHThrVQ HgiGdk5Yh632vjOm9L4sd/GCEACVQKjsu98e8o3ysitFlznEns5EAAXEbITrgKWXDDUWGYxd pnjj2u+GkVdsOAGk0kxczX6s+VRBhpbBI2PWnOsRJgU2n10PZ3mZD4Xu9kU2IXYmuW+e5KCA vTArRUdCrAtIa1k01sPipPPw6dfxx2e5asy21YOytzxuWFfJTGnVxZZSCyLUO83sh6OZhJkk b9rxL9wPmpN/t2IPaEKoAc0FTQZS36wAMOXkBh24PQ9gaLJvfPKpNzGD8XWR5HHF0NLIJhgg 4ZlEXQ2fVp3XrtocHqhu4UZR4koCijgB8sB7Tb0GCpwK+C4UePdFLfhKyRdSXuvY3AHJd4CP 4JzW0Bzq/WXY3XMOzUTYApGQpnUpdOmuQSfpV9MQO+/jo7r6yPbxT7CwRS5dcQPzUiuHLK9i nvjREdh84qycnx0/6dDroYhp0DFv4udxuAvt1h4wGwTPRQZerSm4xaYegEFusyhbZrI0U9tJ B8WrhBLXDiYlyJT6zOV2yZFuW47VrLsjYnHwn27hmxTC/7tvG3euCklmkn9Sl9IAKFu29RSo d5bD8kMSCYsTqtTfT6W4A3qHGvIDta3ptLYpIAOD2sY3GYq2nf3Bbzx81wZK14JdDDHUX2Rs 6+ahAA==
  • Cc: Kevin Tian <kevin.tian@xxxxxxxxx>, Paul Durrant <paul@xxxxxxx>, Wei Liu <wl@xxxxxxx>, Jan Beulich <JBeulich@xxxxxxxx>, Roger Pau Monne <roger.pau@xxxxxxxxxx>
  • Delivery-date: Wed, 11 Mar 2020 18:04:10 +0000
  • Ironport-sdr: gj1dKWB7ZfjywyamQSFZD/i6Y4V+M1PlYmhLtiQiJuFCCdgAXAUB9YwlCeMzHUfVd/aOI/hy3E qyn/4bxUFIoGM5y0w3oYc7auTg90gXvKwPyiOFDhwENnR+uXxqeepSYRb1ZE2EFzq271MGif+z Ze/gQlFjXq8Av28y/ZYXx+Y8eVRD018rT3Q9ndw6SAUd1XxQKwUNYjs76Hdj48TP2g5sX9hRgl bpk3V/xiLqX82O9fiMygfB3bF81Hp+Y5afzZXpQLje2q+Gl9bso1sC+yeFlY3quIFEQZ9emfLW Z6g=
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

Hello,

Testing has encountered this deadlock:

(XEN) Watchdog timer detects that CPU0 is stuck!
(XEN) ----[ Xen-4.14.0-9.0.4-d  x86_64  debug=y   Not tainted ]----
(XEN) CPU:    0
(XEN) RIP:    e008:[<ffff82d08022d6ae>] _spin_lock+0x34/0x5e
(XEN) RFLAGS: 0000000000000002   CONTEXT: hypervisor (d0v0)
(XEN) rax: 0000000000009a44   rbx: ffff8308466712b8   rcx: 0000000000009a45
(XEN) rdx: ffff8308466712b8   rsi: 0000000000009a44   rdi: ffff8308466712be
(XEN) rbp: ffff8300952c7b08   rsp: ffff8300952c7af8   r8:  0000000000000000
(XEN) r9:  0000000000000000   r10: 0000000000000000   r11: 0000000000000000
(XEN) r12: ffff8308466712be   r13: ffff83084665a000   r14: 0000000000555e52
(XEN) r15: 0000000000000002   cr0: 000000008005003b   cr4: 00000000001526e0
(XEN) cr3: 0000000555e52000   cr2: ffff820060001008
(XEN) fsb: 0000000000000000   gsb: 0000000000000000   gss: ffff8e80987a0000
(XEN) ds: 0000   es: 0000   fs: 0000   gs: 0000   ss: 0000   cs: e008
(XEN) Xen code around <ffff82d08022d6ae> (_spin_lock+0x34/0x5e):
(XEN)  da 89 c1 f3 90 66 8b 02 <66> 39 c1 75 f6 4c 89 e7 e8 85 fe ff ff
48 8d 05
(XEN) Xen stack trace from rsp=ffff8300952c7af8:
(XEN)    ffff830846671000 ffff820060001008 ffff8300952c7b58 ffff82d0803219d7
(XEN)    ffff8308466712b8 0000000000000086 ffff82d08038d979 ffff8300952c7bd8
(XEN)    ffff820060001008 0000000000000000 0000000000000000 0000000000000001
(XEN)    ffff8300952c7bc8 ffff82d080356332 0000000000000046 ffff82d08038d96d
(XEN)    0000000000000000 000000008038d96d ffff82d08038d979 ffff82d08038d96d
(XEN)    ffff82d08038d979 ffff83084665a000 0000000000000000 0000000000000000
(XEN)    ffff8300952c7fff 0000000000000000 00007cff6ad38407 ffff82d08038da3d
(XEN)    0000000000000001 00000000005d4a49 ffff83084665a000 0000000000000080
(XEN)    ffff8300952c7c88 000000000000005e 0000048ee9d28fde 0000048ee9c2fae4
(XEN)    0000000000002000 0000000000000000 0000000000000001 000000000000001e
(XEN)    0000000000000022 0000000000000080 ffff820060001008 0000000e00000000
(XEN)    ffff82d08031729f 000000000000e008 0000000000010016 ffff8300952c7c80
(XEN)    0000000000000000 ffff830846671000 ffff8300952c7cd8 ffff82d080321a4d
(XEN)    ffff8308466712b8 0000000000000086 0000000000557140 00000000b6a065fa
(XEN)    ffff830555e6e000 0000000010000000 00007d2000000000 ffff8305571a4000
(XEN)    ffff8300952c7d08 ffff82d08029eeb2 ffff830555e6e000 ffff830846671000
(XEN)    0000000000000000 ffff830555e6e000 ffff8300952c7d28 ffff82d080299f5a
(XEN)    ffff830555e6e000 ffff830555e6e000 ffff8300952c7d48 ffff82d08029a3f7
(XEN)    ffff8300952c7d48 ffff83084665a000 ffff8300952c7da8 ffff82d08031d796
(XEN)    ffff8300952c7d78 ffff8300952c7ef8 ffff8300952c7d78 ffff82d08029e684
(XEN) Xen call trace:
(XEN)    [<ffff82d08022d6ae>] R _spin_lock+0x34/0x5e
(XEN)    [<ffff82d0803219d7>] F map_domain_page+0x250/0x527
(XEN)    [<ffff82d080356332>] F do_page_fault+0x420/0x780
(XEN)    [<ffff82d08038da3d>] F
x86_64/entry.S#handle_exception_saved+0x68/0x94
(XEN)    [<ffff82d08031729f>] F __find_next_zero_bit+0x28/0x69
(XEN)    [<ffff82d080321a4d>] F map_domain_page+0x2c6/0x527
(XEN)    [<ffff82d08029eeb2>] F nvmx_update_exec_control+0x1d7/0x323
(XEN)    [<ffff82d080299f5a>] F vmx_update_cpu_exec_control+0x23/0x40
(XEN)    [<ffff82d08029a3f7>] F
arch/x86/hvm/vmx/vmx.c#vmx_ctxt_switch_from+0xb7/0x121
(XEN)    [<ffff82d08031d796>] F
arch/x86/domain.c#__context_switch+0x124/0x4a9
(XEN)    [<ffff82d080320925>] F context_switch+0x154/0x62c
(XEN)    [<ffff82d080252f3e>] F
common/sched/core.c#sched_context_switch+0x16a/0x175
(XEN)    [<ffff82d080253877>] F common/sched/core.c#schedule+0x2ad/0x2bc
(XEN)    [<ffff82d08022cc97>] F common/softirq.c#__do_softirq+0xb7/0xc8
(XEN)    [<ffff82d08022cd38>] F do_softirq+0x18/0x1a
(XEN)    [<ffff82d0802a2fbb>] F vmx_asm_do_vmentry+0x2b/0x30
(XEN)
(XEN) CPU1 @ e008:ffff82d080252d45 (sched_context_switched+0xa3/0x132)
(XEN) CPU7 @ e008:ffff82d08022d6ae (_spin_lock+0x34/0x5e)
(XEN) CPU3 @ e008:ffff82d08022d6ae (_spin_lock+0x34/0x5e)
(XEN) CPU5 @ e008:ffff82d08022d6ab (_spin_lock+0x31/0x5e)
(XEN) CPU4 @ e008:ffff82d08022d547 (common/spinlock.c#got_lock+0x7/0x23)
(XEN) CPU6 @ e008:ffff82d08025318a
(common/sched/core.c#sched_wait_rendezvous_in+0x241/0x39e)
(XEN) CPU2 @ e008:ffff82d08022d6ae (_spin_lock+0x34/0x5e)
(XEN)
(XEN) ****************************************
(XEN) Panic on CPU 0:
(XEN) FATAL TRAP: vector = 2 (nmi)
(XEN) [error_code=0000] , IN INTERRUPT CONTEXT
(XEN) ****************************************
(XEN)
(XEN) Reboot in five seconds...
(XEN) Executing kexec image on cpu0
(XEN) Shot down all CPUs

This is ultimately cased by c47984aab "nvmx: implement support for MSR
bitmaps", which adds a map_domain_page() call in the middle of
context_switch(), which isn't safe.

Specifically, this is a switch from an HVM vcpu, to a PV vcpu, where the
mapcache code tries to access the per-domain mappings on the HVM monitor
table.  It ends up trying to recursively acquire the mapcache lock while
trying to walk %cr2 to identify the source of the fault.

For nvmx->msr_merged, this needs to either be a xenheap page, or a
globally mapped domheap page.  I'll draft a patch in a moment.

For map_domain_page(), is there anything we can rationally do to assert
that it isn't called in the middle of a context switch?  This is the
kind of thing which needs to blow up reliably in a debug build.

~Andrew

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.