Re: [Xen-devel] [PATCH OSSTEST v5 4/5] examine: detect IOMMU availability and add it as a hostflag

[Ian Jackson <ian.jackson@xxxxxxxxxx>]

Roger Pau Monne writes ("[PATCH OSSTEST v5 4/5] examine: detect IOMMU 
availability and add it as a hostflag"):
> Introduce a new test to check for iommu availability and add it as a
> hostflag if found.
> 
> Signed-off-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
> ---
> Changes since v4:
>  - Split out code into separate patches.
> 
> Changes since v3:
>  - Fail if `xl info` command fails.
> 
> Changes since v2:
>  - Allow flags to be removed.
>  - Fix set_flag addition to HostBD/Static.pm.
> ---
>  sg-run-job       |  1 +
>  ts-examine-iommu | 32 ++++++++++++++++++++++++++++++++
>  2 files changed, 33 insertions(+)
>  create mode 100755 ts-examine-iommu
> 
> diff --git a/sg-run-job b/sg-run-job
> index 7c58d4ba..f6bfdfd5 100755
> --- a/sg-run-job
> +++ b/sg-run-job
> @@ -679,6 +679,7 @@ proc examine-host-examine {install} {
>      if {$ok} {
>       run-ts -.  =           ts-examine-serial-post + host
>       run-ts .   =           ts-examine-logs-save   + host
> +     run-ts .   =           ts-examine-iommu       + host
>       run-ts .   =           ts-examine-hostprops-save

Thanks.  I looked at your test flight and that caused me to notice
that this ts-examine-iommu is in the wrong place, at least logically
speaking.  Log capture should come last, just before -hostprops-save.

So can you swap -logs-save and -iommu please ?

Thanks,
Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel