[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Xen-devel] [PATCH v3 18/19] hw/arm: Do not build to 'virt' machine on Xen
- To: Peter Maydell <peter.maydell@xxxxxxxxxx>
- From: Philippe Mathieu-Daudé <philmd@xxxxxxxxxx>
- Date: Mon, 16 Mar 2020 20:00:26 +0100
- Cc: Fam Zheng <fam@xxxxxxxxxx>, Thomas Huth <thuth@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, kvm-devel <kvm@xxxxxxxxxxxxxxx>, Paul Durrant <paul@xxxxxxx>, Richard Henderson <richard.henderson@xxxxxxxxxx>, QEMU Developers <qemu-devel@xxxxxxxxxx>, qemu-arm <qemu-arm@xxxxxxxxxx>, "open list:X86" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Anthony Perard <anthony.perard@xxxxxxxxxx>, Paolo Bonzini <pbonzini@xxxxxxxxxx>, Alex Bennée <alex.bennee@xxxxxxxxxx>
- Delivery-date: Mon, 16 Mar 2020 19:00:49 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 3/16/20 6:11 PM, Peter Maydell wrote:
On Mon, 16 Mar 2020 at 16:08, Philippe Mathieu-Daudé <philmd@xxxxxxxxxx> wrote:
Xen on ARM does not use QEMU machines [*]. Disable the 'virt'
machine there to avoid odd errors such:
CC i386-softmmu/hw/cpu/a15mpcore.o
hw/cpu/a15mpcore.c:28:10: fatal error: kvm_arm.h: No such file or directory
[*]
https://wiki.xenproject.org/wiki/Xen_ARM_with_Virtualization_Extensions#Use_of_qemu-system-i386_on_ARM
Signed-off-by: Philippe Mathieu-Daudé <philmd@xxxxxxxxxx>
---
Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>
Cc: Anthony Perard <anthony.perard@xxxxxxxxxx>
Cc: Paul Durrant <paul@xxxxxxx>
Cc: xen-devel@xxxxxxxxxxxxxxxxxxxx
---
hw/arm/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/hw/arm/Kconfig b/hw/arm/Kconfig
index 8e801cd15f..69a8e30125 100644
--- a/hw/arm/Kconfig
+++ b/hw/arm/Kconfig
@@ -1,5 +1,6 @@
config ARM_VIRT
bool
+ depends on !XEN
default y if KVM
imply PCI_DEVICES
imply TEST_DEVICES
--
This seems odd to me:
(1) the error message you quote is for a15mpcore.c, not virt.c
This is the first device the virt board selects:
config ARM_VIRT
bool
imply PCI_DEVICES
imply TEST_DEVICES
imply VFIO_AMD_XGBE
imply VFIO_PLATFORM
imply VFIO_XGMAC
imply TPM_TIS_SYSBUS
select A15MPCORE
...
(2) shouldn't this be prevented by something saying "don't build
guest architecture X boards into Y-softmmu", rather than a specific
flag for a specific arm board ?
Yes, agreed. This surgical change was quicker for my testing, but we
don't need this patch right now, so let's drop it.
thanks
-- PMM
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel
|
