Re: [Xen-devel] [XEN PATCH] mismatch between pyxc_methods flags and PyObject definitions

[Wei Liu <wl@xxxxxxx>]

On Tue, Mar 24, 2020 at 03:32:26AM +0100, Marek Marczykowski-Górecki wrote:
> On Tue, Mar 17, 2020 at 11:01:43PM +0000, YOUNG, MICHAEL A. wrote:
> > pygrub in xen-4.13.0 with python 3.8.2 fails with the error
> > 
> > Traceback (most recent call last):
> >   File "/usr/libexec/xen/bin/pygrub", line 21, in <module>
> >     import xen.lowlevel.xc
> > SystemError: bad call flags
> > 
> > This patch fixes mismatches in tools/python/xen/lowlevel/xc/xc.c
> > between the flag bits defined in pyxc_methods and the parameters passed
> > to the corresponding PyObject definitions.
> > 
> > With this patch applied pygrub works as expected.
> > 
> > Signed-off-by: Michael Young <m.a.young@xxxxxxxxxxxx>
> 
> This looks like a change in Python 3.7 (according to the documentation,
> might not be enforced there yet). Python <= 3.6 allowed METH_KEYWORDS
> used alone. Fortunately, all the versions supports METH_VARARGS |
> METH_KEYWORDS, which looks to be equivalent to old METH_KEYWORDS alone.
> 
> Acked-by: Marek Marczykowski-Górecki <marmarek@xxxxxxxxxxxxxxxxxxxxxx>

Thanks. I added "tools/python" to the subject line and committed this
patch.

Ian, this needs to be backported to at least 4.13 since we started
supported Python 3 in that version.

Backport: 4.13

Wei.