[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 0/5] use new API for Xen page tables



On Sun, 2020-03-29 at 16:06 +0100, Wei Liu wrote:
> On Mon, Mar 23, 2020 at 09:41:37AM +0000, Hongyan Xia wrote:
> > From: Hongyan Xia <hongyxia@xxxxxxxxxx>
> > 
> > This small series is basically just rewriting functions using the
> > new
> > API to map and unmap PTEs. Each patch is independent.
> > 
> > Apart from mapping and unmapping page tables, no other functional
> > change
> > intended.
> > 
> 
> The code looks correct to me.
> 
> I do wonder if you should've put your SoB instead of Rb in some of
> the
> patches.

I am not exactly sure what the policy is. For a couple of the patches,
I did not touch anything but just cherry-picked from your tree, and
what I did was just looking at the code and double checking, so I put
an Rb there. Will change to SoB if this is not how we do things.

Hongyan




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.