[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 7/7] xen/guest_access: Fix coding style in xen/guest_access.h

On 07/04/2020 09:17, Jan Beulich wrote:
On 04.04.2020 15:10, Julien Grall wrote:
From: Julien Grall <jgrall@xxxxxxxxxx>

     * Add space before and after operator
     * Align \
     * Format comments

To be honest, despite the reason you give for the split in patch 6,
I'd rather see code movement like this to do formatting adjustments
right away.

Thank you for thinking I can move code and also modify coding style at the same time :).

However I know mistakes can be easily made and may not be caught during review (possibly leading to an XSA). So I tend to adhere to the KISS principle.

But if you're convinced the split is better, I'm not
meaning to insist.

I will keep the code as-is unless someone else think it is bad idea.


Julien Grall



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.