[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [XEN PATCH v4 17/18] build, include: rework compat-build-source.py
On 31.03.2020 12:31, Anthony PERARD wrote: > Improvement are: > - give the path to xlat.lst as argument > - include `grep -v` in compat-build-source.py script, we don't need to > write this in several scripted language. > - have 'xlat.lst' path as a variable. The change looks okay, but I'm unsure whether it's really worthwhile. I specifically dislike the last point above, as it makes things less easy to read. I might be willing to ack a patch with this part taken out again; faod I'm not meaning to nak the patch in its current form, but I guess I'm also not going to ack it. Jan
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |