[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [XEN PATCH] libxc/migration: Abort migration on precopy policy request [and 1 more messages]



Panyakin, Andrew writes ("Re: [XEN PATCH] libxc/migration: Abort migration on 
precopy policy request"):
> On 4/7/20 10:22 PM, Wei Liu wrote:
> > There is no need to have "goto out" here.
> 
> I was considering two more examples of "goto out" in a branch right before 
> the label:
> - send_domain_memory_nonlive,
> - send_domain_memory_live.
> 
> Isn't it done this way to simplify the function extension: you won't need to 
> add "goto out" to previous branch when adding new code?

Quite so.

Wei Liu writes ("Re: [XEN PATCH] libxc/migration: Abort migration on precopy 
policy request"):
> I'm not too fussed about this. Let's keep goto out.

Good :-).

> Acked-by: Wei Liu <wl@xxxxxxx>
> 
> I will apply this patch shortly.

Thanks,
Ian.



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.