Re: [PATCH v2 3/3] xen/x86: ioapic: Simplify ioapic_init()

[Julien Grall <julien@xxxxxxx>]

Hi Jan,

On 06/04/2020 14:24, Jan Beulich wrote:
> On 04.04.2020 12:26, Julien Grall wrote:
> > From: Julien Grall <jgrall@xxxxxxxxxx>
> >
> > Since commit 9facd54a45 "x86/ioapic: Add register level checks to detect
> > bogus io-apic entries", Xen is able to cope with IO APICs not mapped in
> > the fixmap.
> >
> > Therefore the whole logic to allocate a fake page for some IO APICs is
> > unnecessary.
> >
> > With the logic removed, the code can be simplified a lot as we don't
> > need to go through all the IO APIC if SMP has not been detected or a
> > bogus zero IO-APIC address has been detected.
> >
> > To avoid another level of tabulation, the simplification is now moved in
> > its own function.
> >
> > Signed-off-by: Julien Grall <jgrall@xxxxxxxxxx>
> Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>
Thank you! I took the liberty to push them.

Cheers,

--
Julien Grall