[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 02/12] xen/arm: introduce arch_xen_dom_flags and direct_map
- To: Jan Beulich <jbeulich@xxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>
- From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- Date: Wed, 15 Apr 2020 12:27:53 +0100
- Authentication-results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none; spf=None smtp.pra=andrew.cooper3@xxxxxxxxxx; spf=Pass smtp.mailfrom=Andrew.Cooper3@xxxxxxxxxx; spf=None smtp.helo=postmaster@xxxxxxxxxxxxxxx
- Cc: julien@xxxxxxx, Wei Liu <wl@xxxxxxx>, George Dunlap <George.Dunlap@xxxxxxxxxxxxx>, Ian Jackson <ian.jackson@xxxxxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx, Stefano Stabellini <stefano.stabellini@xxxxxxxxxx>, Volodymyr_Babchuk@xxxxxxxx, Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Delivery-date: Wed, 15 Apr 2020 11:28:06 +0000
- Ironport-sdr: 0SI/xKFLtmGLJ7Li0CWH4uAESkufqJmMq31Bf5mbRhrgDHyhJqbccm+GqU6Wf4t08T/7uYcca1 nXhU7DSDb1507I03ZxWgNoRRmuoh/aapJDcyAld0fbTJ68xpnCwbxXdklj0+eaznViozbFDDRP t5lQaswwVGnFCfx6YirPb4wQ6xLr7kv++KqCGqTLWLN4gTisK3se8qwOtCTmZYKlJnNakelUrE vX4VMIL9kWLBKBdDNgqzJl1fQluw3quZE1y8VIULbDnjHTvsiQaJjOuMwITDSi6WHFV5nqzIz5 2tM=
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 15/04/2020 11:27, Jan Beulich wrote:
> On 15.04.2020 03:02, Stefano Stabellini wrote:
>> --- a/xen/arch/arm/domain.c
>> +++ b/xen/arch/arm/domain.c
>> @@ -682,6 +682,7 @@ int arch_domain_create(struct domain *d,
>> return 0;
>>
>> ASSERT(config != NULL);
>> + d->arch.direct_map = flags != NULL ? flags->arch.is_direct_map : false;
> Shouldn't "true" here imply ->disable_migrate also getting
> set to true? Or is this already the case anyway for domains
> created right at boot?
Please don't introduce any more uses for disable_migrate. It is
fundamentally broken and won't survive to 4.14 (assuming that the 30 odd
patches of prereq fixes on xen-devel start unblocking themselves in time)
~Andrew
|
