Re: [PATCH v3 1/4] x86/shim: map and unmap page tables in replace_va_mapping

[Jan Beulich <jbeulich@xxxxxxxx>]

On 15.04.2020 13:59, Hongyan Xia wrote:
> From: Wei Liu <wei.liu2@xxxxxxxxxx>
> 
> Also, introduce lYe_from_lXe() macros which do not rely on the direct
> map when walking page tables. Unfortunately, they cannot be inline
> functions due to the header dependency on domain_page.h, so keep them as
> macros just like map_lYt_from_lXe().
> 
> Signed-off-by: Wei Liu <wei.liu2@xxxxxxxxxx>
> Signed-off-by: Hongyan Xia <hongyxia@xxxxxxxxxx>
> 
> ---
> Changed in v3:
> - use unmap_domain_page() instead of the macro in several places.
> - also introduce l1e_from_l2e().
> - add _ prefix in macros to avoid aliasing.

Why prefixes, violating name space rules? In my reply to v2
requesting the adjustment I specifically said "suffixes".

Jan