[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 0/8] Fix build with using OCaml 4.06.1 and -safe-string


Gentle ping. I am missing reviews for the OCaml part.


On 30/03/2020 20:21, Julien Grall wrote:
From: Julien Grall <jgrall@xxxxxxxxxx>

Hi all,

This series is meant to solve the build issue reported by Dario when
using recent version of OCaml and -safe-string.

I took the opportunity to harden a bit more the code by using const more

This series was only build tested.


Julien Grall (8):
   xen/guest_access: Harden copy_to_guest_offset to prevent const dest
   xen/public: sysctl: set_parameter.params and debug.keys should be
   tools/libxc: misc: Mark const the parameter 'keys' of
   tools/libxc: misc: Mark const the parameter 'params' of
   tools/ocaml: libxc: Check error return in stub_xc_vcpu_context_get()
   tools/ocaml: libxb: Harden stub_header_of_string()
   tools/ocaml: libxb: Avoid to use String_val() when value is bytes
   tools/ocaml: Fix stubs build when OCaml has been compiled with

  tools/libxc/include/xenctrl.h       |  4 ++--
  tools/libxc/xc_misc.c               |  8 ++++----
  tools/libxc/xc_private.h            |  8 ++++++++
  tools/ocaml/libs/xb/xenbus_stubs.c  |  6 +++---
  tools/ocaml/libs/xb/xs_ring_stubs.c | 12 ++++++++++--
  tools/ocaml/libs/xc/xenctrl_stubs.c |  6 ++++--
  xen/include/asm-arm/guest_access.h  |  2 +-
  xen/include/asm-x86/guest_access.h  |  2 +-
  xen/include/public/sysctl.h         |  4 ++--
  9 files changed, 35 insertions(+), 17 deletions(-)

Julien Grall



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.