RE: [PATCH 09/11] xen/pt: Fix flawed conversion to realize()

[Paul Durrant <xadimgnik@xxxxxxxxx>]

> -----Original Message-----
> From: Markus Armbruster <armbru@xxxxxxxxxx>
> Sent: 20 April 2020 09:33
> To: qemu-devel@xxxxxxxxxx
> Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>; Anthony Perard 
> <anthony.perard@xxxxxxxxxx>; Paul
> Durrant <paul@xxxxxxx>; xen-devel@xxxxxxxxxxxxxxxxxxxx
> Subject: [PATCH 09/11] xen/pt: Fix flawed conversion to realize()
> 
> The conversion of xen_pt_initfn() to xen_pt_realize() blindly replaced
> XEN_PT_ERR() by error_setg().  Several error conditions that did not
> fail xen_pt_initfn() now fail xen_pt_realize().  Unsurprisingly, the
> cleanup on these errors looks highly suspicious.
> 
> Revert the inappropriate replacements.
> 
> Fixes: 5a11d0f7549e24a10e178a9dc8ff5e698031d9a6
> Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>
> Cc: Anthony Perard <anthony.perard@xxxxxxxxxx>
> Cc: Paul Durrant <paul@xxxxxxx>
> Cc: xen-devel@xxxxxxxxxxxxxxxxxxxx
> Signed-off-by: Markus Armbruster <armbru@xxxxxxxxxx>

Reviewed-by: Paul Durrant <paul@xxxxxxx>