[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [PATCH v3] Introduce a description of the Backport and Fixes tags
On 20.04.2020 12:27, Wei Liu wrote: > On Mon, Apr 20, 2020 at 10:31:28AM +0100, Julien Grall wrote: >> On 17/04/2020 23:24, Stefano Stabellini wrote: >>> Create a new document under docs/process to describe our special tags. >>> Add a description of the Fixes tag and the new Backport tag. Also >>> clarify that lines with tags should not be split. >>> >>> Signed-off-by: Stefano Stabellini <stefano.stabellini@xxxxxxxxxx> >>> CC: Ian Jackson <ian.jackson@xxxxxxxxxxxxx> >>> CC: Wei Liu <wl@xxxxxxx> >>> CC: jbeulich@xxxxxxxx >>> CC: george.dunlap@xxxxxxxxxx >>> CC: julien@xxxxxxx >>> CC: lars.kurth@xxxxxxxxxx >>> CC: andrew.cooper3@xxxxxxxxxx >>> CC: konrad.wilk@xxxxxxxxxx >>> --- >>> Removing Acks as I added the description of "Fixes" >>> --- >>> docs/process/tags.pandoc | 55 ++++++++++++++++++++++++++++++++++++++++ >>> 1 file changed, 55 insertions(+) >>> create mode 100644 docs/process/tags.pandoc >>> >>> diff --git a/docs/process/tags.pandoc b/docs/process/tags.pandoc >>> new file mode 100644 >>> index 0000000000..06b06dda01 >>> --- /dev/null >>> +++ b/docs/process/tags.pandoc >>> @@ -0,0 +1,55 @@ >>> +Tags: No line splitting >>> +----------------------- >>> +Do not split a tag across multiple lines, tags are exempt from the >>> +"wrap at 75 columns" rule in order to simplify parsing scripts. For >>> +example: >>> + >>> + Fixes: 67d01cdb5 ("x86: infrastructure to allow converting certain >>> indirect calls to direct ones") >> >> The SHA-1 ID is 9 characters but... >> >>> + >>> + >>> +Fixes Tag >>> +--------- >>> + >>> +If your patch fixes a bug in a specific commit, e.g. you found an issue >>> using >>> +``git bisect``, please use the 'Fixes:' tag with the first 12 characters of >>> +the SHA-1 ID, and the one line summary. >> >> ... you request 12 characters here. Can you make sure the two match please? >> >> However, I am not entirely sure why we should mandate 12 characters. With >> the title, you should always be able to find back the commit if there is a >> clash. > > This is copied from Linux's document. > > I normally use 8-9 characters, but I don't mind using 12 either. Are they still saying 9? I've been asked to switch to 12 several weeks back ... Jan
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |