Xen project Mailing List

Re: [PATCH] x86/shadow: make sh_remove_write_access() helper HVM only

To: Jan Beulich <jbeulich@xxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>

From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>

Date: Tue, 21 Apr 2020 13:06:37 +0100

Authentication-results: esa6.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none; spf=None smtp.pra=andrew.cooper3@xxxxxxxxxx; spf=Pass smtp.mailfrom=Andrew.Cooper3@xxxxxxxxxx; spf=None smtp.helo=postmaster@xxxxxxxxxxxxxxx

Cc: Tim Deegan <tim@xxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>

Delivery-date: Tue, 21 Apr 2020 12:06:46 +0000

Ironport-sdr: 0P02j3QqbONlKvcutAPWqJZdrE/2CPFs12A/Ddem9i9YTJRyD605q2losRnp4ilFF582bIc0XT aAMKVXLNJsCxM9dduL/RJVylE5uUQP+7KuA6+AkPiO6p9n+a6c5uIPB3sZ/Neb3ii9TSLCsFQh Zaarp1QURL16EzQ/nQB5Hs/09qGBfi1ZySW4Sm8mrR04KnouXd0j5Q5/ImdLeUKOHEP00rXw2O JLfKGgoVK2DHrMXCT/Ffc2cEEQagXhPgLJRsfZhR26lwceEYrmagokjWRfZLccwcjujgPz91Sj iP0=

List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 21/04/2020 13:05, Jan Beulich wrote: > Despite the inline attribute at least some clang versions warn about > trace_shadow_wrmap_bf() being unused in !HVM builds. Include the helper > in the #ifdef region. > > Fixes: 8b8d011ad868 ("x86/shadow: the guess_wrmap() hook is needed for HVM > only") > Reported-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx> > Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx> Reviewed-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>

©2013 Xen Project, A Linux Foundation Collaborative Project. All Rights Reserved.
Linux Foundation is a registered trademark of The Linux Foundation.
Xen Project is a trademark of The Linux Foundation.